Skip to content
This repository has been archived by the owner on Jul 12, 2019. It is now read-only.

Feature/prep dao #58

Merged
merged 43 commits into from
Feb 8, 2019
Merged

Feature/prep dao #58

merged 43 commits into from
Feb 8, 2019

Conversation

Velenir
Copy link
Contributor

@Velenir Velenir commented Feb 5, 2019

This PR is intended to be for the actual DAO deployment

Only changes for now are to env variables in env_vars/dao.env
Config is src/config not changed, only added comments to easily see calculated vars

Dry run log is available in deployment-mainnet-dryrun.txt

@Velenir Velenir requested a review from anxolin February 5, 2019 16:57
Copy link
Contributor

@orenyodfat orenyodfat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mention which issues this pr is fixing

@orenyodfat
Copy link
Contributor

does this pr include the parameters for the real dxDAO ?

"prettier-plugin-solidity-refactor": "^1.0.0-alpha.14",
"scrypt": "^6.0.3",
"truffle-contract": "^4.0.4",
"truffle-hdwallet-provider": "^1.0.3"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove CR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the issue

@anxolin
Copy link
Contributor

anxolin commented Feb 6, 2019

please mention which issues this pr is fixing

All of the ones u opened :)

#57
#55
#54
#53

Anyways, the purpose of the branch is settle the config params for dxDAO and this test

@anxolin anxolin merged commit fb79540 into master Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants