This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new env variables * add deployment logs and networks
This reverts commit b01536d.
orenyodfat
suggested changes
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please mention which issues this pr is fixing
does this pr include the parameters for the real dxDAO ? |
orenyodfat
reviewed
Feb 6, 2019
orenyodfat
reviewed
Feb 6, 2019
"prettier-plugin-solidity-refactor": "^1.0.0-alpha.14", | ||
"scrypt": "^6.0.3", | ||
"truffle-contract": "^4.0.4", | ||
"truffle-hdwallet-provider": "^1.0.3" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove CR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the issue
anxolin
approved these changes
Feb 6, 2019
orenyodfat
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to be for the actual DAO deployment
Only changes for now are to env variables in
env_vars/dao.env
Config is
src/config
not changed, only added comments to easily see calculated varsDry run log is available in
deployment-mainnet-dryrun.txt