Skip to content

Fix Windows test coverage #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Fix Windows test coverage #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions cmd_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,7 @@ func TestCmdNonzeroExit(t *testing.T) {
}

func TestCmdStop(t *testing.T) {
t.Skip("FIXME")

// Count to 3 sleeping 5s between counts. The long sleep is because we want
// to kill the proc right after count "1" to ensure Stdout only contains "1"
// and also to ensure that the proc is really killed instantly because if
// it's not then timeout below will trigger.
p := cmd.NewCmd(path.Join(".", "test", "count-and-sleep"), "3", "5")
p := cmd.NewCmd("sleep", "5")

// Start process in bg and get chan to receive final Status when done
statusChan := p.Start()
Expand Down Expand Up @@ -135,13 +129,13 @@ func TestCmdStop(t *testing.T) {
gotStatus.StopTs = 0

expectStatus := cmd.Status{
Cmd: "./test/count-and-sleep",
PID: gotStatus.PID, // nondeterministic
Complete: false, // signaled by Stop
Exit: -1, // signaled by Stop
Error: errors.New("signal: terminated"), // signaled by Stop
Runtime: gotStatus.Runtime, // nondeterministic
Stdout: []string{"1"},
Cmd: "sleep",
PID: gotStatus.PID, // nondeterministic
Complete: false,
Exit: 1,
Error: nil,
Runtime: gotStatus.Runtime, // nondeterministic
Stdout: []string{},
Stderr: []string{},
}
if diffs := deep.Equal(gotStatus, expectStatus); diffs != nil {
Expand Down