Skip to content

Conversation

greut
Copy link
Contributor

@greut greut commented May 24, 2020

I've been experimenting with the streaming option and it seems that it misses the last line if that one isn't terminated by a carriage return.

Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@coveralls
Copy link

coveralls commented May 24, 2020

Coverage Status

Coverage decreased (-1.0%) to 99.035% when pulling fe4165a on greut:flush-then-close into a151197 on go-cmd:master.

@coveralls
Copy link

coveralls commented May 24, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling b66c7d8 on greut:flush-then-close into a151197 on go-cmd:master.

Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@daniel-nichter daniel-nichter merged commit 6f93998 into go-cmd:master Oct 31, 2020
@daniel-nichter
Copy link
Member

Sorry for the slow response. Thanks for the fix, PR, and test! I'll merge and tweak the test a little: keep the original, then add a new one specifically for this.

@greut greut deleted the flush-then-close branch October 31, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants