Revert "Prevent a user with a different email from accepting the team…

… invite" (#24531) Reverts #24491
go-gitea · May 5, 2023 · 3ee7f27 · 3ee7f27
1 parent 4218404
commit 3ee7f27
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 26 deletions.
diff --git a/options/locale/locale_en-US.ini b/options/locale/locale_en-US.ini
@@ -2561,7 +2561,6 @@ teams.all_repositories_admin_permission_desc = This team grants <strong>Admin</s
 teams.invite.title = You've been invited to join team <strong>%s</strong> in organization <strong>%s</strong>.
 teams.invite.by = Invited by %s
 teams.invite.description = Please click the button below to join the team.
-teams.invite.email_mismatch = Your email address does not match this invite.
 
 [admin]
 dashboard = Dashboard

diff --git a/routers/web/org/teams.go b/routers/web/org/teams.go
@@ -552,7 +552,6 @@ func TeamInvite(ctx *context.Context) {
 	ctx.Data["Organization"] = org
 	ctx.Data["Team"] = team
 	ctx.Data["Inviter"] = inviter
-	ctx.Data["EmailMismatch"] = ctx.Doer.Email != invite.Email
 
 	ctx.HTML(http.StatusOK, tplTeamInvite)
 }
@@ -569,13 +568,6 @@ func TeamInvitePost(ctx *context.Context) {
 		return
 	}
 
-	// check that the Doer is the invitee
-	if ctx.Doer.Email != invite.Email {
-		log.Info("invite %d does not apply to the current user %d", invite.ID, ctx.Doer.ID)
-		ctx.NotFound("ErrTeamInviteNotFound", err)
-		return
-	}
-
 	if err := models.AddTeamMember(team, ctx.Doer.ID); err != nil {
 		ctx.ServerError("AddTeamMember", err)
 		return

diff --git a/templates/org/team/invite.tmpl b/templates/org/team/invite.tmpl
@@ -6,23 +6,17 @@
 			<div class="image">
 				{{avatar $.Context .Organization 140}}
 			</div>
-			{{if .EmailMismatch}}
-				<div class="content">
-					<div class="header">{{.locale.Tr "org.teams.invite.email_mismatch"}}</div>
-				</div>
-			{{else}}
-				<div class="content">
-					<div class="header">{{.locale.Tr "org.teams.invite.title" .Team.Name .Organization.Name | Str2html}}</div>
-					<div class="meta">{{.locale.Tr "org.teams.invite.by" .Inviter.Name}}</div>
-					<div class="description">{{.locale.Tr "org.teams.invite.description"}}</div>
-				</div>
-				<div class="extra content">
-					<form class="ui form" action="" method="post">
-						{{.CsrfTokenHtml}}
-						<button class="fluid ui green button">{{.locale.Tr "org.teams.join"}}</button>
-					</form>
-				</div>
-			{{end}}
+			<div class="content">
+				<div class="header">{{.locale.Tr "org.teams.invite.title" .Team.Name .Organization.Name | Str2html}}</div>
+				<div class="meta">{{.locale.Tr "org.teams.invite.by" .Inviter.Name}}</div>
+				<div class="description">{{.locale.Tr "org.teams.invite.description"}}</div>
+			</div>
+			<div class="extra content">
+				<form class="ui form" action="" method="post">
+					{{.CsrfTokenHtml}}
+					<button class="fluid ui green button">{{.locale.Tr "org.teams.join"}}</button>
+				</form>
+			</div>
 		</div>
 	</div>
 </div>