Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go-org module to latest release #12727

Closed
Iced-Sun opened this issue Sep 5, 2020 · 1 comment · Fixed by #12728
Closed

update go-org module to latest release #12727

Iced-Sun opened this issue Sep 5, 2020 · 1 comment · Fixed by #12728

Comments

@Iced-Sun
Copy link

Iced-Sun commented Sep 5, 2020

go-org receives quite a few bug-fixes and enhancements since v0.1.9. Would it be possible to update go-org to the latest version? Thanks.

zeripath added a commit to zeripath/gitea that referenced this issue Sep 5, 2020
Fix go-gitea#12727

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor

zeripath commented Sep 5, 2020

Hi!

For future reference should you want to create a PR that updates a dependency do:

git checkout -b update-${dependency} master
go get -u ${dependency}
make vendor
git status
# add missing files with git add
git commit -sm'Update ${dependency}

This PR updates the ${dependency} to version ${version}.
'
git push your-fork update-${dependency}

and then open a PR for us.

It's helpful if you can add a few details about the versions changed.

techknowlogick pushed a commit that referenced this issue Sep 5, 2020
* Update to go-org 1.3.2

Fix #12727

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Fix unit test

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants