Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Optional pronoun field in profile #13990

Open
Alch-Emi opened this issue Dec 15, 2020 · 6 comments
Open

[Feature Request] Optional pronoun field in profile #13990

Alch-Emi opened this issue Dec 15, 2020 · 6 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@Alch-Emi
Copy link

Hi all!

Summary

I'm proposing to add a new field to the user biography, specifically for pronouns. Like the website, location, and bio fields, the user would not be required to use this field, and if they elected to leave it out, the field would not be displayed. If the field is set, it would be displayed alongside a small icon, such as octicons-comment-discussion. Input to the field would be 64 characters of free text.

Demo

Motivation

The process of building software, especially in a community-focused open source environment, makes inevitable the need to refer to other contributors in the third person. This creates a problem, as English, and many other languages, have multiple third-person pronouns to refer to users. On the internet, there's often no easy way to tell which is appropriate.

While using they/them pronouns (as in, “Alex mentioned in their review that…”) for every user of the site works, it might not be the ideal solution, especially as users become more integrated into projects, and people still don't know how to refer to them.

Considerations

  • If a user does not want to specify their pronouns then this change would not affect them. As with the other profile fields, a pronoun field could be hidden when empty, meaning their bio (and that of anyone else who hasn't engaged with the feature) will look exactly the same
  • If a sysadmin is working under a size constraint or a user is connecting on a low bandwidth connection this should not increase the size of the application nor payload considerably. The icon proposed is already included in the octicons icon set currently in use by Gitea, and the example depicted in the image should add only 226 bytes, including whitespace and newlines.
  • If a user who uses a non-English language or a user who uses non-standard pronouns needs to use Gitea, they may specify pronouns appropriate to their language, or enter any non-standard or case-specific pronouns, since the input field is agnostic to content beyond accepting no more than 64 characters. Even very specific, multi-language pronouns could easily be specified within this space (“DE: er/ihn, EN: he/him or they/them” is only 35 characters [Note: I don't actually know German, apologies if this is a misrepresentation of how people present their pronouns in German]). A user whose language does not include multiple personal pronouns and does not speak a language that does my simply leave the field blank.
  • If an unprivileged but registered user is looking to abuse the system this addition should not grant them any leverage that they didn't already have. The amount of text that may be entered is small (smaller, in fact, than other fields in the bio), and should not expose any attack vectors not already available in the other fields. The implementation should seek to apply the same safety checks as are used in these fields to ensure this.
  • If a user seeks to use the field to communicate some other information then this change fully enables them to do so. Although the UI encourages the use of the field to communicate pronouns, any other 64 characters that may be accompanied by the octicons-comment-discussion is entirely possible. This does not undermine the feature motivation, as users who do not want to share their pronouns will always be welcome to, and granting users more freedom will not hurt.

Other Discussions & Notes

I was unable to find any other issues or pull requests discussing the addition of a pronoun field, nor any other additional or custom field. The closest related issue I could find was #4339, calling for the addition of a user biography. This issue has since been implemented and closed. The only criticism of the request was that it may be out of scope. To address this concern in relation to this request, I do not believe that this should be out of scope for the project. I would suggest Gitea is just as much about discussion and collaboratively building code as it is about the code itself, and that the knowledge of how to correctly refer to your fellow collaborators is just as important as knowing things such as their location or website, if not more so.

I'm willing to try to implement this feature myself, but I'm opening an issue to get some advice and input from the community, and to respect the Gitea contribution workflow. I'd be happy to address any concerns or accept constructive criticism, such that this thread might be a better resource either to me or a future developer

@jolheiser
Copy link
Member

It seems like a user could just put this in their bio, no?

@techknowlogick
Copy link
Member

The bio field is free form to cover this case, just like you are achieving in you GitHub profile currently.

@Alch-Emi
Copy link
Author

Respectfully, I'd like to appeal the decision to close this. While the bio field absolutely works to convey pronouns, and I'm happy that it's an option, I see it as a stopgap at best.

While people can use the bio field to convey pronouns, people typically don't use the bio field. I think adding a specific pronoun field would encourage users to share their pronouns, which many people would find beneficial.

Additionally, if a user chooses to use the pronoun field to share their pronouns, they are forced to either cram their bio into the space after their pronouns, or cram their pronouns into the space after their bio.

I do recognize that for most users, this will be a small change, but I do think it will be a net positive for many users. I'd argue that UX is often the summation of many small things just like this.

I think that this would provide a lot of benefit to a lot of people, with next to no cost for most other users. I am also more than willing to do the devwork if that itself is a concern.

I'd at least like to request that the issue be kept open so that we might discuss it.

@techknowlogick
Copy link
Member

This is exactly the purpose of the bio field to provide biographical information on who the user is. If the issue is that no one uses something, that's not a vote of confidence for adding yet another field that won't be used. If the issue is that users need to cram in information into the bio field, then the field should be expanded to accommodate this. Unfortunately, UX can also be negatively impacted by having too many fields so adding new ones we need to be careful.

@Alch-Emi
Copy link
Author

Alch-Emi commented Dec 15, 2020

Thank you for the response. While I do see where you're coming from, I believe you've overlooked some key things.

If the issue is that no one uses something, that's not a vote of confidence for adding yet another field that won't be used.

I don't believe that this is true, nor that this reflects the current attitude of Gitea towards other fields. As I interpret it, you're suggesting to justify a feature, if another feature can be used to that end, then users are using that feature to that end. In this case, this feature is invalid because the bio field can be used to that end, but only a few users are using it that way. If this is the case, I'm happy to open up a new issue to remove the location field. This field can easily be replaced by the bio field, though I doubt too many users would immediately use it for that.

If the issue is that users need to cram in information into the bio field, then the field should be expanded to accommodate this.

I think I may have used poor wording here. I meant to refer to visual or cognitive cramming of one's bio. For example, the following bio does not run up against the space limit, but is very much crammed:

[he/him] An entrepreneuring FOSS developer (22 y/o) [Student, CalTech]

In this sense, cramming is solved not by extending the field itself, but by allowing users to present their information in a more ordered fashion, in this case by adding more fields. I'm not arguing that we should add an age field, a job field, and a hair color field, but add a select few specialized fields for very important information, as has been done with Location.

Unfortunately, UX can also be negatively impacted by having too many fields so adding new ones we need to be careful.

I wholeheartedly agree, and Gitea's exactly-as-much-as-it-needs-to-be UI is the biggest reason I love it over GitLab and GitHub. I've been working in Gitea via a friend's instance for a while, fell in love with the UX enough that I've started the process of working on my own instance, and will be migrating my projects over soon. I wholeheartedly understand the need to avoid cluttering the UI. However, I think that this change, between the fact that it only actually shows up when filled, but provides a very important service, falls squarely on the "worthwhile" end of this spectrum.

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
@techknowlogick techknowlogick reopened this Oct 5, 2023
@go-gitea go-gitea unlocked this conversation Oct 5, 2023
@techknowlogick
Copy link
Member

Re-opening as we now have the user key/value table which means this could be implemented without needing a migration or another column.

@techknowlogick techknowlogick added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Oct 5, 2023
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this issue Apr 6, 2024
**Backport:** https://codeberg.org/forgejo/forgejo/pulls/1518

An attempt at adding an optional pronoun field for user profiles, as suggested here 3 years ago: go-gitea/gitea#13990

![A Forgejo profile showing pronouns to the right of the user's username](/attachments/2e5ff300-d333-46db-9074-f030f199843c)

I made this for [my own instance](https://git.gay/h) and didn't initially think I'd make a PR because of the previous closed issue, but I thought I'd ask the Forgejo matrix chat to see if there was any support and there was!

I'm told I should make a database migration, some help as to how to do that would be appreciated.

Co-authored-by: hazycora <hazysu@riseup.net>
Co-authored-by: Gergely Nagy <forgejo@gergo.csillger.hu>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3076
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
Co-committed-by: forgejo-backport-action <forgejo-backport-action@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants