UI issue in Pull Request/Files menu: When expanding the code, the code is show into a small viewbox #18516
Comments
This was referenced Feb 1, 2022
Merged
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Feb 1, 2022
Backport go-gitea#18502 Currently the "File Changed" tab of a PR is somehow broken. This is also true for the current release 1.16.0. When you are on the "File Changed" tab, and want to look at code excerpt before or after the code changes, the layout breaks. You can test this on try.gitea.io here: https://try.gitea.io/testnotexisting/magic_enum/pulls/2/files The problem occurs for the unified view and for the split view. Kind of the same problem was there for commenting a line of code, this was fixed in go-gitea#18321 and go-gitea#18403. For consistency, I changed the solution of go-gitea#18321, I removed the ``colspan`` and instead added a ``<td>``. The goal was to have code similarly with the split view. Also the separator line in the split view was in the wrong column, this was fixed too.* more consistent unified review comment Fix go-gitea#18516 Co-authored-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this issue
Feb 2, 2022
Backport #18502 Currently the "File Changed" tab of a PR is somehow broken. This is also true for the current release 1.16.0. When you are on the "File Changed" tab, and want to look at code excerpt before or after the code changes, the layout breaks. You can test this on try.gitea.io here: https://try.gitea.io/testnotexisting/magic_enum/pulls/2/files The problem occurs for the unified view and for the split view. Kind of the same problem was there for commenting a line of code, this was fixed in #18321 and #18403. For consistency, I changed the solution of #18321, I removed the ``colspan`` and instead added a ``<td>``. The goal was to have code similarly with the split view. Also the separator line in the split view was in the wrong column, this was fixed too.* more consistent unified review comment Fix #18516 Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: confusedsushi <confused.sushi@googlemail.com>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
Currently the "File Changed" tab of a PR is somehow broken. This is also true for the current release 1.16.0. When you are on the "File Changed" tab, and want to look at code excerpt before or after the code changes, the layout breaks. You can test this on try.gitea.io here: https://try.gitea.io/testnotexisting/magic_enum/pulls/2/files The problem occurs for the unified view and for the split view. Kind of the same problem was there for commenting a line of code, this was fixed in go-gitea#18321 and go-gitea#18403. For consistency, I changed the solution of go-gitea#18321, I removed the ``colspan`` and instead added a ``<td>``. The goal was to have code similarly with the split view. Also the separator line in the split view was in the wrong column, this was fixed too.* more consistent unified review comment Fix go-gitea#18516 Co-authored-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Gitea Version
1.16.0
Operating System
Windows 10
Browser Version
Chrome v97
Can you reproduce the bug on the Gitea demo site?
Yes
Description
When expendaning to see more code in the Pull Request Files menu, the code is shrunk into a small viewbox:
Exemple: https://try.gitea.io/bartvm/test-pull-request/pulls/1/files
Screenshots
Before:
After:
The text was updated successfully, but these errors were encountered: