Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore history button and hide add button when unable to add #20718

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 8, 2022

Fix two regressions from #20602:

  • Restore the 'History' button that was previously unable to render because it's show condition was never hit. Also added a icon to it.
  • Hide the 'Add File' button when there would be no items in the dropdown, e.g. when user is not logged in.

Screen Shot 2022-08-08 at 20 12 49

image

View this PR with whitespace changes hidden.

Fix two regressions from go-gitea#20602:

- Restore the 'History' button that was previously unable to render
  because it's show condition was never hit
- Hide the 'Add File' button when there would be no items in the
  dropdown.
@silverwind silverwind added this to the 1.18.0 milestone Aug 8, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 9, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 9, 2022
@wxiaoguang wxiaoguang merged commit 33b03e8 into go-gitea:main Aug 9, 2022
@silverwind silverwind deleted the btnfixes branch August 9, 2022 10:57
silverwind added a commit to silverwind/gitea that referenced this pull request Aug 9, 2022
…ea#20718)

Fix two regressions from go-gitea#20602:

- Restore the 'History' button that was previously unable to render
  because it's show condition was never hit
- Hide the 'Add File' button when there would be no items in the
  dropdown.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 10, 2022
* giteaofficial/main:
  Fix CI status popup (go-gitea#20737)
  Add documentation about pagination of the API (go-gitea#20740)
  [skip ci] Updated translations via Crowdin
  Change commit status icons to SVG (go-gitea#20736)
  Add support for NuGet API keys (go-gitea#20721)
  Keep download count on Container tag overwrite (go-gitea#20728)
  Replace fomantic popup module with tippy.js (go-gitea#20428)
  Add an option to create new issues from "/issues" page (go-gitea#20650)
  Restore history button and hide add button when unable to add (go-gitea#20718)
  Remove manual rollback for failed generated repositories (go-gitea#20639)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
…ea#20718)

Fix two regressions from go-gitea#20602:

- Restore the 'History' button that was previously unable to render
  because it's show condition was never hit
- Hide the 'Add File' button when there would be no items in the
  dropdown.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zeripath pushed a commit that referenced this pull request Aug 20, 2022
* Rework repo buttons (#20602)

* Rework repo buttons

- Replace "New PR" and "Go to File" button with Icon Button
- Move all "Add File" actions into a dropdown button
- Remove most custom styling of clone buttons
- Margin and wiki tweaks

Buttons are now all equal height, mobile layout wraps gracefully.

Fixes: #13671
Replaces: #20375

* Restore history button and hide add button when unable to add (#20718)

Fix two regressions from #20602:

- Restore the 'History' button that was previously unable to render
  because it's show condition was never hit
- Hide the 'Add File' button when there would be no items in the
  dropdown.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@zeripath zeripath added the backport/done All backports for this PR have been created label Aug 21, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants