-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue that sync_on_commit
is not set
#21309
Conversation
sync_on_commit
is not setsync_on_commit
is not set
Should it be something like:
? |
|
I think it's a bug and the PR is worth to be backported to 1.17. @harryzcy do you have time to send a backport? |
No, I believe 'sync-on-commit' feature is only added to 1.18, and not to 1.17. So we don't need to backport this fix to 1.17. |
Oh yes, I missed that. 👍 let's mark it as skip-changelog |
Fixes #21308.
With the original frontend template
templates/repo/settings/options.tmpl
, the fieldpush_mirror_sync_on_commit
is always empty even when checkbox is checked. Removingvalue
from the input tag seems to solve the issue, and will setpush_mirror_sync_on_commit: on
when the checkbox is checked.(I'm not familiar with the frontend logics Gitea is using, so I don't really understand the cause of it)