Fix issue that sync_on_commit is not set

[harryzcy]

Fixes #21308.

With the original frontend template templates/repo/settings/options.tmpl, the field push_mirror_sync_on_commit is always empty even when checkbox is checked. Removing value from the input tag seems to solve the issue, and will set push_mirror_sync_on_commit: on when the checkbox is checked.

(I'm not familiar with the frontend logics Gitea is using, so I don't really understand the cause of it)

[wxiaoguang]

Should it be something like:

{{if .push_mirror_sync_on_commit}} checked {{/if}}

?

[harryzcy]

Should it be something like:

{{if .push_mirror_sync_on_commit}} checked {{/if}}

?

{{if .push_mirror_sync_on_commit}}checked{{end}} works. Thank you!

[wxiaoguang]

I think it's a bug and the PR is worth to be backported to 1.17. @harryzcy do you have time to send a backport?

[harryzcy]

I think it's a bug and the PR is worth to be backported to 1.17. @harryzcy do you have time to send a backport?

No, I believe 'sync-on-commit' feature is only added to 1.18, and not to 1.17. So we don't need to backport this fix to 1.17.

[wxiaoguang]

Oh yes, I missed that. 👍 let's mark it as skip-changelog