Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord webhook maxes out at 5 commits #21379

Closed
TheBrokenRail opened this issue Oct 8, 2022 · 0 comments · Fixed by #21400
Closed

Discord webhook maxes out at 5 commits #21379

TheBrokenRail opened this issue Oct 8, 2022 · 0 comments · Fixed by #21400
Labels

Comments

@TheBrokenRail
Copy link
Contributor

Description

If you setup a Discord webhook with Gitea and push more than 5 commits, it will only show 5 commits and will only say you pushed 5 commits.

While it makes sense to truncate the amount of commits shown on the Discord embed, the issue is that the text says that only 5 commits were pushed and the the link only shows 5 commits.

(Test Repository: https://try.gitea.io/TheBrokenRail/Discord-Webhook-Bug)

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

Can't find any relevant logs for webhooks.

Screenshots

Screenshot from 2022-10-08 16-44-45

Git Version

2.36.2

Operating System

Ubuntu + Docker

How are you running Gitea?

I'm using the official Docker image.

Database

SQLite

wxiaoguang added a commit that referenced this issue Oct 16, 2022
Fixes #21379

The commits are capped by `setting.UI.FeedMaxCommitNum` so
`len(commits)` is not the correct number. So this PR adds a new
`TotalCommits` field.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
KN4CK3R added a commit to KN4CK3R/gitea that referenced this issue Oct 16, 2022
Fixes go-gitea#21379

The commits are capped by `setting.UI.FeedMaxCommitNum` so
`len(commits)` is not the correct number. So this PR adds a new
`TotalCommits` field.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant