Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Use vertical style secondary navbar in all-level settings #24229

Closed
2 of 3 tasks
HesterG opened this issue Apr 20, 2023 · 1 comment
Closed
2 of 3 tasks

[Proposal] Use vertical style secondary navbar in all-level settings #24229

HesterG opened this issue Apr 20, 2023 · 1 comment
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@HesterG
Copy link
Contributor

HesterG commented Apr 20, 2023

Feature Description

Right now the secondary nav bar on settings pages on user/admin/repo levels are horizontal.

Example from admin:

Screen Shot 2023-04-20 at 16 05 39

While the nav bar on organization level is vertical:

Screen Shot 2023-04-20 at 16 06 45

It is better to also use vertical style for user/admin/repo levels, because as more settings are added, a horizontal scrollbar occurs on the horizontal navbar, which is not very friendly to use. Whereas the vertical navbar can be folded so it can hold more items. Like the one in github.

And for this to look better, also propose to change the overall width of ui.container first, on large device (laptops/desktops, between 992px and 1200px), the page with a vertical navbar looks fine (like the screenshot above). But on extra large device (large laptops and desktops, 1200px and up), ui.container is only 1127px in total, so overall the navbar and the contents look crowded in the middle (Also in other pages):

Screen Shot 2023-04-20 at 16 18 38

Some Step:

  • Change html only to change from horizontal to vertical navbar
  • Change css (like width) to make the contents less crowded
  • Change some of the routers to make some settings submenus

Screenshots

No response

@HesterG HesterG added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/ui Change the appearance of the Gitea UI labels Apr 20, 2023
@HesterG HesterG changed the title [Proposal] Change secondary navbar in all level settings to vertical style [Proposal] Use vertical style secondary navbar in all-level settings Apr 20, 2023
@lunny lunny removed the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 20, 2023
@silverwind
Copy link
Member

silverwind commented Apr 20, 2023

Agree, these scrollable horizontal navbars are weird. Pages like Org settings already have vertical nav, so you can copy the HTML structure from there.

@silverwind silverwind added the proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. label Apr 20, 2023
lunny pushed a commit that referenced this issue Apr 23, 2023
…dmin settings (#24246)

Co-Author: @wxiaoguang 

This is the first step of #24229. And this PR will only includes html
changes, and followed by other PRs that fine tune css and change to
submenus.

After:

Admin Level

<img width="1400" alt="Screen Shot 2023-04-21 at 10 07 16"
src="https://user-images.githubusercontent.com/17645053/233523870-f848b61d-056a-4b41-9760-a9a49fea1fe8.png">

User Level

<img width="1422" alt="Screen Shot 2023-04-21 at 10 07 23"
src="https://user-images.githubusercontent.com/17645053/233523878-979adb20-a657-43d9-99a6-ad414010c0ef.png">

Repo Level

<img width="1404" alt="Screen Shot 2023-04-21 at 10 07 07"
src="https://user-images.githubusercontent.com/17645053/233523863-337440bd-c03a-4dfd-87fa-cef40300bfe0.png">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
techknowlogick pushed a commit that referenced this issue Apr 26, 2023
…g header (#24315)

Close #24302 
Part of #24229, Follows #24246
This PR focused on CSS style fine-tune, main changes:

1. Give `.ui.ui.ui.container` a width of `1280px` with a max-width of
`calc(100vw - 64px)`, so the main contents looks better on large
devices.

2. Share styles for table elements in all levels settings pages to fix
overflow of runners table on mobile and for consistency (The headers on
mobile can be further improved, but haven't found a proper way yet).

3. Use [stackable
grid](https://fomantic-ui.com/collections/grid.html#stackable) and
[device column width](https://fomantic-ui.com/examples/responsive.html)
for responsiveness for some pages (repo/org collaborators settings
pages, org teams related page)

4. Fixed #24302 by sharing label related CSS in reporg.css

5. Fine tune repo tags settings page

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
proposal/accepted We have reviewed the proposal and agree that it should be implemented like that/at all. topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

4 participants