Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Missing 404 swagger response docs for /admin/users/{username} #26079

Closed
lonix1 opened this issue Jul 24, 2023 · 1 comment · Fixed by #26086
Closed

[Docs] Missing 404 swagger response docs for /admin/users/{username} #26079

lonix1 opened this issue Jul 24, 2023 · 1 comment · Fixed by #26086
Assignees
@CaiCandong
Labels
modifies/api This PR adds API routes or modifies them type/bug type/docs This PR mainly updates/creates documentation

Comments

@lonix1
Copy link
Contributor

lonix1 commented Jul 24, 2023

Description

The swagger endpoint /admin/users/{username} is missing the response 404.

When the account does not exist then the API returns 404 - but that is not shown in the swagger docs.

Gitea Version

1.21.0+dev-354-g24c3bb95a

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

n/a

Screenshots

No response

Git Version

n/a

Operating System

n/a

How are you running Gitea?

n/a

Database

None
@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation modifies/api This PR adds API routes or modifies them labels Jul 24, 2023
@CaiCandong
Copy link
Member

I was able to reproduce the problem, and I'm going to propose a PR to fix swagger's documentation

@CaiCandong CaiCandong mentioned this issue Jul 24, 2023
Merged
KN4CK3R pushed a commit that referenced this issue Jul 24, 2023
@CaiCandong
fix Missing 404 swagger response docs for /admin/users/{username} (#2…
4211efe 
…6086)

close #26079
@GiteaBot GiteaBot mentioned this issue Jul 24, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jul 24, 2023
@CaiCandong @GiteaBot
fix Missing 404 swagger response docs for /admin/users/{username} (go…
5a52e4f 
…-gitea#26086)

close go-gitea#26079
KN4CK3R pushed a commit that referenced this issue Jul 24, 2023
@GiteaBot @CaiCandong
fix Missing 404 swagger response docs for /admin/users/{username} (#2…
5971354 
…6086) (#26089)

Backport #26086 by @CaiCandong

close #26079

Co-authored-by: caicandong <50507092+CaiCandong@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CaiCandong CaiCandong

Labels
modifies/api This PR adds API routes or modifies them type/bug type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Missing 404 swagger response docs for /admin/users/{username} CaiCandong/gitea
3 participants
@techknowlogick @lonix1 @CaiCandong