Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve modal dialog UI #26764

Merged
merged 3 commits into from Aug 28, 2023
Merged

Improve modal dialog UI #26764

merged 3 commits into from Aug 28, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Aug 28, 2023 •
edited

  1. Fine tune the CSS styles, and add more examples
  2. Add necessary "dimmer" animation for modal dialogs, otherwise the UI seems flicking (follow Remove fomantic transition module #26469)

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2023
@wxiaoguang wxiaoguang added this to the 1.21.0 milestone Aug 28, 2023
@wxiaoguang wxiaoguang added the topic/ui Change the appearance of the Gitea UI label Aug 28, 2023
@silverwind
Copy link
Member

This "dimmer" module should be removed/replaced as well eventually. I already tried once in #24937.

@wxiaoguang
Copy link
Contributor Author

In this PR, there is only one line added for the "dimmer": .ui.dimmer.transition {

Other changes are all for the modal dialog.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 28, 2023
@wxiaoguang wxiaoguang enabled auto-merge (squash) August 28, 2023 22:36
@wxiaoguang wxiaoguang merged commit 0ab70d4 into go-gitea:main Aug 28, 2023
24 checks passed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 29, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
764a683 
* giteaofficial/main:
  Add fix incorrect can_create_org_repo for org owner team (go-gitea#26683)
  [skip ci] Updated translations via Crowdin
  Improve modal dialog UI (go-gitea#26764)
  Improve the "bug report" template and "support options" document (go-gitea#26753)
  Unify `border-radius` behavior (go-gitea#26770)
  Reduce some allocations in type conversion (go-gitea#26772)
  Refactor some CSS styles and simplify code (go-gitea#26771)
  Add auth-required to config.json for Cargo http registry (go-gitea#26729)
  refactor(API): refactor secret creation and update functionality (go-gitea#26751)
@wxiaoguang wxiaoguang deleted the improve-modal branch September 1, 2023 12:37
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot