Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): add routes and functions for managing user's secrets #26909

Merged
merged 6 commits into from Sep 5, 2023

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Sep 5, 2023

  • Add routes for creating or updating a user's actions secrets in routers/api/v1/api.go
  • Add a new file routers/api/v1/user/action.go with functions for creating or updating a user's secrets and deleting a user's secret
  • Modify the templates/swagger/v1_json.tmpl file to include the routes for creating or updating a user's secrets and deleting a user's secret

- Add routes for creating or updating a user's actions secrets in `routers/api/v1/api.go`
- Add a new file `routers/api/v1/user/action.go` with functions for creating or updating a user's secrets and deleting a user's secret
- Modify the `templates/swagger/v1_json.tmpl` file to include the routes for creating or updating a user's secrets and deleting a user's secret

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 5, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2023
@appleboy appleboy changed the title feat: add routes and functions for managing user's secrets feat(API): add routes and functions for managing user's secrets Sep 5, 2023
@appleboy appleboy added the modifies/api This PR adds API routes or modifies them label Sep 5, 2023
@appleboy appleboy added this to the 1.21.0 milestone Sep 5, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 5, 2023
routers/api/v1/user/action.go Outdated Show resolved Hide resolved
routers/api/v1/user/action.go Outdated Show resolved Hide resolved
@KN4CK3R KN4CK3R enabled auto-merge (squash) September 5, 2023 12:07
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 5, 2023
@lunny
Copy link
Member

lunny commented Sep 5, 2023

make generate-swagger is necessary.

@KN4CK3R KN4CK3R merged commit f79f6a2 into go-gitea:main Sep 5, 2023
24 checks passed
@appleboy appleboy deleted the user branch September 5, 2023 14:23
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 6, 2023
* giteaofficial/main:
  Add missing translation (go-gitea#26926)
  Vendor `jquery.are-you-sure` with strict mode fixes (go-gitea#26901)
  Fix the secret regexp pattern on web page (go-gitea#26910)
  Add @chenrui333 as maintainer (go-gitea#26917)
  Move notification interface to services layer (go-gitea#26915)
  fetch emails of currently displayed user on admin page (go-gitea#26918)
  Improve LDAP group config documentation, fixes go-gitea#21159 (go-gitea#21227)
  update footer link to new landing page (go-gitea#26916)
  Remove `Named` interface (go-gitea#26913)
  Refactor secrets modification logic (go-gitea#26873)
  Add missing `reqToken()` to notifications endpoints (go-gitea#26914)
  feat(API): add routes and functions for managing user's secrets (go-gitea#26909)
  Move feed notification service layer (go-gitea#26908)
  Extract common code to new template (go-gitea#26903)
  Move ui notification to service layer (go-gitea#26907)
  Remove duplicated notify mail configuration on tests (go-gitea#26912)
  Move indexer notification to service layer (go-gitea#26906)

# Conflicts:
#	templates/base/footer_content.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants