Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Oauth2 causes 500 #27223

Closed
earthjasonlin opened this issue Sep 24, 2023 · 2 comments · Fixed by #27269
Closed

GitHub Oauth2 causes 500 #27223

earthjasonlin opened this issue Sep 24, 2023 · 2 comments · Fixed by #27269
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@earthjasonlin
Copy link

Description

I first set up GitHub in /admin/auths, everything should be right, but when i try to connect to it with my account in /user/settings/security, it succeeds. I can now login with my GitHub account, but when i open /user/settings/security again, it gives this error and I can't see my account in Manage Linked Accounts section.
On demo site, I can link account to GitHub and don't get this 500 error on the page, but I still cant see my GitHub account listed in Manage Linked Accounts

2023/09/24 13:05:21 .../context_response.go:86:HTML() [E] Render failed: failed to render template: user/settings/security/security, error: template error: builtin(bindata):user/settings/security/accountlinks:32:20 : executing "user/settings/security/accountlinks" at <$providerData.IconHTML>: wrong number of args for IconHTML: want 1 got 0
----------------------------------------------------------------------
					{{$providerData.IconHTML}}
					               ^
----------------------------------------------------------------------

Gitea Version

1.22.0+dev-17-g6e2888ce2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image
image

Git Version

No response

Operating System

No response

How are you running Gitea?

docker-compose with nightly tag

Database

SQLite

@lng2020
Copy link
Member

lng2020 commented Sep 25, 2023

Currently, both https://try.gitea.io and https://gitea.com have this error.

@lng2020 lng2020 added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 25, 2023
@wxiaoguang
Copy link
Contributor

Regression of #27122

lunny pushed a commit that referenced this issue Sep 26, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Sep 26, 2023
wxiaoguang added a commit that referenced this issue Sep 26, 2023
Backport #27269 by @wxiaoguang

Fix #27223

Regression of #27122

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants