-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download and pushing translations #2727
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2727 +/- ##
=======================================
Coverage 26.84% 26.84%
=======================================
Files 89 89
Lines 17608 17608
=======================================
Hits 4727 4727
Misses 12195 12195
Partials 686 686 Continue to review full report at Codecov.
|
c53a7d4
to
ccd3577
Compare
download_translations: | ||
image: jonasfranz/crowdin | ||
pull: true | ||
secrets: [ crowdin_key ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be added to drone server right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is already added during the upload process
.drone.yml
Outdated
git_push: | ||
image: appleboy/drone-git-push | ||
pull: true | ||
secrets: [ git_push_ssh_key ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you should add the gut_push_ssh_key like described in the plug-in documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the git_push_ssh_key
in drone secret.
.drone.yml
Outdated
commit_message: "[skip ci] Updated translations via Crowdin" | ||
when: | ||
event: [ push ] | ||
branch: [ master ] | ||
pre-build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an empty line between every pipeline steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
LGTM |
LGTM |
The CI build (https://drone.gitea.io/go-gitea/gitea/1582/6) fails due to an issue with the git push plug-in. Do somebody know why? |
Replaces: #2592 because of rebase problems
This PR adds the following build steps:
download_translations: Downloads & exports all translations from crowdin and saves them into options/locale/
upload_translations: Uploads the updated locale_en-US.ini to Crowdin
The build steps are splitted because the files should only uploaded to crowdin if all test passes.
It also adds the ignore_branch option to fix the build process because gitea does not use branches at crowdin.
This is already tested here:
Upload & Export in custom folder: http://drone.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/12
Used configuration: https://git.jonasfranz.software/JonasFranzDEV/Crowdin-Demo/src/master/.drone.yml
Related to #2585
Related to jonasfranz/drone-crowdin#2