Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use subselect in DeleteIssuesByRepoID #27332

Merged
merged 3 commits into from Oct 3, 2023
Merged

Don't use subselect in DeleteIssuesByRepoID #27332

merged 3 commits into from Oct 3, 2023

Conversation

JakobDev
Copy link
Contributor

Part of https://codeberg.org/forgejo/discussions/issues/61

This is workaround for a bug in MariaDB

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 28, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 28, 2023
delvh
delvh reviewed Sep 28, 2023
View reviewed changes
models/issues/issue_update.go Show resolved Hide resolved
models/issues/issue_update.go Outdated Show resolved Hide resolved
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 30, 2023
@lunny lunny added this to the 1.22.0 milestone Sep 30, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 30, 2023
@delvh delvh added backport/v1.21 This PR should be backported to Gitea 1.21 performance/speed performance issues with slow downs labels Sep 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 2, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2023
@lunny lunny enabled auto-merge (squash) October 3, 2023 07:38
@lunny lunny merged commit 08507e2 into go-gitea:main Oct 3, 2023
26 checks passed
@GiteaBot GiteaBot mentioned this pull request Oct 3, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 3, 2023
@JakobDev @GiteaBot
Don't use subselect in DeleteIssuesByRepoID (go-gitea#27332)
59af920 
Part of https://codeberg.org/forgejo/discussions/issues/61

This is workaround for a bug in MariaDB
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 3, 2023
@JakobDev JakobDev deleted the issuedeletesped branch October 3, 2023 08:38
lunny pushed a commit that referenced this pull request Oct 3, 2023
@GiteaBot @JakobDev
Don't use subselect in DeleteIssuesByRepoID (#27332) (#27408)
d5da0e6 
Backport #27332 by @JakobDev

Part of https://codeberg.org/forgejo/discussions/issues/61

This is workaround for a bug in MariaDB

Co-authored-by: JakobDev <jakobdev@gmx.de>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh left review comments

@lunny lunny lunny approved these changes

@puni9869 puni9869 puni9869 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JakobDev @lunny @delvh @puni9869 @GiteaBot