Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let API add 2 exclusive labels from same scope (#27433) #27460

Merged
merged 1 commit into from Oct 5, 2023

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Oct 5, 2023

Backport #27433 by @JakobDev

Fixes #27380

@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them type/bug labels Oct 5, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Oct 5, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 5, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 5, 2023
@silverwind silverwind enabled auto-merge (squash) October 5, 2023 15:36
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 5, 2023
@silverwind silverwind merged commit 44aca6a into go-gitea:release/v1.21 Oct 5, 2023
26 checks passed
@MarkusAmshove
Copy link
Contributor

When there is already an existing label from a scope and I post a single label from the same scope, is the old label removed automatically?

In the test thats added by this PR there are two labels posted at the same time.

@JakobDev
Copy link
Contributor

When there is already an existing label from a scope and I post a single label from the same scope, is the old label removed automatically?

Yes

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants