Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid run change title process when the title is same #27467

Merged
merged 2 commits into from Oct 6, 2023
Merged

Avoid run change title process when the title is same #27467

merged 2 commits into from Oct 6, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Oct 6, 2023 •
edited

If user only changed the target branch or just did nothing and clicked the Save button, you will see the change log as following:
image

This makes no sense, so we should check whether the title is surely changed before run the ChangeTitle.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 6, 2023
@yp05327 yp05327 changed the title Avoid change title when the target title is as same as the old title Avoid run change title process when the target title is as same as the old title Oct 6, 2023
@yp05327 yp05327 changed the title Avoid run change title process when the target title is as same as the old title Avoid run change title process when the title is same Oct 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 6, 2023
@silverwind silverwind added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2023
@delvh delvh added backport/v1.20 This PR should be backported to Gitea 1.20 type/enhancement An improvement of existing functionality topic/ui-interaction Change the process how users use Gitea instead of the visual appearance labels Oct 6, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) October 6, 2023 17:11
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 6, 2023
@techknowlogick techknowlogick merged commit 5a7ab86 into go-gitea:main Oct 6, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 6, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Oct 6, 2023

I was unable to create a backport for 1.20. @yp05327, please send one manually. 🍵

go run ./contrib/backport 27467
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 6, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 8, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
8b59533 
* giteaoffical/main: (79 commits)
  Pre-register OAuth application for tea (go-gitea#27509)
  Fix mermaid flowchart margin issue (go-gitea#27503)
  add a shortcut to user's profile page to admin user details (go-gitea#27299)
  Fix actionlint (go-gitea#27513)
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#27501)
  Improve feed icons and feed merge text color (go-gitea#27498)
  Downgrade `go-co-op/gocron` to v1.31.1 (go-gitea#27511)
  Enable markdownlint `no-duplicate-header` (go-gitea#27500)
  bump go-deps (go-gitea#27489)
  Apply to became a maintainer (go-gitea#27491)
  change runner for binary
  [skip ci] Updated translations via Crowdin
  Remove .exe suffix when cross-compiling on Windows (go-gitea#27448)
  move re-useable workflow
  add checkout to disk-clean
  use hosted runners for nightly actions (go-gitea#27485)
  Avoid run change title process when the title is same (go-gitea#27467)
  Fix panic in storageHandler (go-gitea#27446)
  Rename the default themes to gitea-light, gitea-dark, gitea-auto (go-gitea#27419)
  ...
@yp05327 yp05327 deleted the add-check-target-issue-title branch October 10, 2023 05:39
This was referenced Oct 10, 2023
Merged
Merged
silverwind pushed a commit that referenced this pull request Oct 10, 2023
@yp05327
Avoid run change title process when the title is same (#27467) (#27557)
e6d1afa 
Backport #27467 manually.
silverwind pushed a commit that referenced this pull request Oct 10, 2023
@yp05327
Avoid run change title process when the title is same (#27467) (#27558)
29d3949 
Backport #27467 manually.
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 5, 2024
@lunny lunny added the backport/done All backports for this PR have been created label Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yp05327 @GiteaBot @silverwind @delvh @lunny @techknowlogick