Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

environment-to-ini lost short-options in 1.21 and k8s helm-chart installation brakes #27913

Closed
fashberg opened this issue Nov 5, 2023 · 0 comments · Fixed by #27914
Closed

environment-to-ini lost short-options in 1.21 and k8s helm-chart installation brakes #27913

fashberg opened this issue Nov 5, 2023 · 0 comments · Fixed by #27914
Labels
type/bug

Comments

@fashberg
Copy link
Contributor

fashberg commented Nov 5, 2023 •
edited
Loading

Description

Hey!

I've upgraded to 1.21.0-rc2 and my k8s installation broke. I'm using the official helm-chart from https://gitea.com/gitea/helm-chart

The init-container init-app-ini shows:

2023/11/05 16:47:53 ...nvironment-to-ini.go:73:main() [F] Failed to run app with [environment-to-ini -o /data/gitea/conf/app.ini]: flag provided but not defined: -o

After some investigation:

It is related to Refactor to use urfave/cli/v2 (#25959).

urfave/cli v2 requires another short-options setup, so the -o Option is gone.

Not fixing this will brake all 1.21 kubernets installation

Gitea Version

1.21.0-rc2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Kubernetes Helm Chart on Linux

Database

None
fashberg added a commit to fashberg/gitea that referenced this issue Nov 5, 2023
@fashberg
Fixing go-gitea#27913
f177e93
@fashberg fashberg mentioned this issue Nov 5, 2023
Merged
@fashberg fashberg changed the title environment-to-ini lost short-options in 1.21 and k8s helm-chart is broken environment-to-ini lost short-options in 1.21 and k8s helm-chart installation brakes Nov 5, 2023
@GiteaBot GiteaBot mentioned this issue Nov 6, 2023
Merged
silverwind pushed a commit that referenced this issue Nov 6, 2023
@fashberg
Update environment-to-ini flag parsing (#27914)
c823af2 
This Fixes #27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 6, 2023
@fashberg @GiteaBot
Update environment-to-ini flag parsing (go-gitea#27914)
9e0a2bd 
This Fixes go-gitea#27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>
silverwind pushed a commit that referenced this issue Nov 6, 2023
@GiteaBot @fashberg
Update environment-to-ini flag parsing (#27914) (#27940)
6eadad8 
Backport #27914 by @fashberg

This Fixes #27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>

Co-authored-by: Folke <folke@ashberg.de>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@fashberg @fuxiaohei
Update environment-to-ini flag parsing (go-gitea#27914)
e516818 
This Fixes go-gitea#27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@fashberg @silverwind
Update environment-to-ini flag parsing (go-gitea#27914)
7516942 
This Fixes go-gitea#27913 

This commit updates `environment-to-ini` to be compatible with update
urfave/cli/v2

Doc: <https://cli.urfave.org/v2/examples/combining-short-options/>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update environment-to-ini flag parsing fashberg/gitea
1 participant
@fashberg