Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure gh binary exists #28053

Closed
6543 opened this issue Nov 14, 2023 · 0 comments · Fixed by #28061
Closed

make sure gh binary exists #28053

6543 opened this issue Nov 14, 2023 · 0 comments · Fixed by #28061
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Milestone
1.21.1

Comments

@6543
Copy link
Member

6543 commented Nov 14, 2023 •
edited
Loading

https://github.com/go-gitea/gitea/actions/runs/6864716362/job/18667116788 :

Run gh release create v1.21.0 --title v1.21.0 --draft --notes-from-tag dist/release/*
/home/runner/work/_temp/df1f597e-b671-4a36-8c9b-df8014b8f9a3.sh: line 1: gh: command not found
Error: Process completed with exit code 127.

affects v1.20.x and main

gitea/.github/workflows/release-tag-version.yml

Lines 61 to 65 in f65977d

- name: create github release
run: |
gh release create ${{ github.ref_name }} --title ${{ github.ref_name }} --draft --notes-from-tag dist/release/*
env:
GITHUB_TOKEN: ${{ secrets.RELEASE_TOKEN }}

also we should make sure gh release dont fail if release was already created and overwrite artifacts (as it was done with drone plugin)
@6543 6543 added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Nov 14, 2023
@6543 6543 added this to the 1.21.1 milestone Nov 14, 2023
@6543 6543 added the type/bug label Nov 14, 2023
@6543 6543 mentioned this issue Nov 15, 2023
Merged
techknowlogick added a commit that referenced this issue Nov 25, 2023
@lunny @techknowlogick
Fix actions when tagging (#28061)
763938e 
close #28053

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@GiteaBot GiteaBot mentioned this issue Nov 25, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Nov 25, 2023
@lunny @techknowlogick @GiteaBot
Fix actions when tagging (go-gitea#28061)
9116bc5 
close go-gitea#28053

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick added a commit that referenced this issue Nov 25, 2023
@GiteaBot @lunny @techknowlogick
Fix actions when tagging (#28061) (#28218)
7f81110 
Backport #28061 by @lunny

close #28053

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2024
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
@lunny @techknowlogick @fuxiaohei
Fix actions when tagging (go-gitea#28061)
c23501c 
close go-gitea#28053

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
@lunny @techknowlogick @silverwind
Fix actions when tagging (go-gitea#28061)
17aecf8 
close go-gitea#28053

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
t2vee pushed a commit to t2vee/forgejo that referenced this issue Jul 5, 2024
@GiteaBot @earl-warren
Fix actions when tagging (#28061) (#28218)
29556fa 
Backport #28061 by @lunny

close go-gitea/gitea#28053

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
(cherry picked from commit 7f81110)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Milestone
1.21.1
Development

Successfully merging a pull request may close this issue.

Fix actions when tagging lunny/gitea
1 participant
@6543