Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty action run title #28113

Merged
merged 8 commits into from Nov 21, 2023
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 18, 2023

Fix #27901

@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 18, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Nov 18, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 18, 2023
@silverwind
Copy link
Member

I guess we should make the string translatable.

@github-actions github-actions bot added modifies/translation and removed modifies/templates This PR modifies the template files labels Nov 20, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2023
@lunny lunny enabled auto-merge (squash) November 21, 2023 02:34
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2023
@lunny lunny merged commit 0c0d17f into go-gitea:main Nov 21, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 21, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 21, 2023
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Nov 21, 2023
lunny added a commit that referenced this pull request Nov 21, 2023
Backport #28113 by @lunny

Fix #27901

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Nov 21, 2023
@@ -3530,7 +3530,7 @@ runs.actors_no_select = All actors
runs.status_no_select = All status
runs.no_results = No results matched.
runs.no_runs = The workflow has no runs yet.
runs.no_commit_message = empty commit message
runs.empty_commit_message = empty commit message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not what I meant. Now you have actions.runs.empty_commit_message, but I wanted empty_commit_message because the next time we need this translation outside of actions context, it will be a ugly usage.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 22, 2023
* giteaofficial/main:
  Fix the description about the default setting for action in quick start document (go-gitea#28160)
  Do not display search box when there's no packages yet (go-gitea#28146)
  Add guide page to actions when there's no workflows (go-gitea#28145)
  Fix no ActionTaskOutput table waring (go-gitea#28149)
  Fix empty action run title (go-gitea#28113)
  Use "is-loading" to avoid duplicate form submit for code comment (go-gitea#28143)
  Fix typo in `packages.cleanup.success` (go-gitea#28133)
  Add edit option for README.md (go-gitea#28071)
  Remove autofocus in search box (go-gitea#28033)
  Add missing `packages.cleanup.success` (go-gitea#28129)
  Update docs for docusaurus v3 (go-gitea#28125)
TommyLike pushed a commit to openmerlin/gitea that referenced this pull request Dec 26, 2023
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lunny lunny deleted the lunny/empty_action_title branch January 27, 2024 09:11
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot click on action link if the commit message is empty
5 participants