Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous id when fetch Actions tasks #30382

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix ambiguous id when fetch Actions tasks #30382

merged 1 commit into from
Apr 10, 2024

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Apr 10, 2024

Fix regression of #30331.

time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous"

I have tested it in my local env, and it should work now.

@wolfogre wolfogre added type/bug topic/gitea-actions related to the actions of Gitea backport/v1.22 This PR should be backported to Gitea 1.22 labels Apr 10, 2024
@wolfogre wolfogre added this to the 1.23.0 milestone Apr 10, 2024
@wolfogre wolfogre requested a review from yp05327 April 10, 2024 02:32
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 10, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 10, 2024
@lunny lunny enabled auto-merge (squash) April 10, 2024 02:39
@lunny lunny merged commit 310e251 into go-gitea:main Apr 10, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 10, 2024
Fix regression of go-gitea#30331.

```txt
time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous"
```
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 10, 2024
lunny pushed a commit that referenced this pull request Apr 10, 2024
Backport #30382 by @wolfogre

Fix regression of #30331.

```txt
time="2024-04-10T02:23:49Z" level=error msg="failed to fetch task" func="[fetchTask]" file="[poller.go:91]" error="unknown: rpc error: code = Internal desc = pick task: CreateTaskForRunner: Error 1052 (23000): Column 'id' in field list is ambiguous"
```

I have tested it in my local env, and it should work now.

Co-authored-by: Jason Song <i@wolfogre.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 10, 2024
* giteaofficial/main:
  Fix line height on inline code preview (go-gitea#30372)
  Refactor more filterslice (go-gitea#30370)
  Fix ambiguous id when fetch Actions tasks (go-gitea#30382)
  Fix floated list items (go-gitea#30377)
  Fix actions design about default actions download url (go-gitea#30360)
  Add container.FilterSlice function (go-gitea#30339)
  Fix label-list rendering in timeline, decrease gap (go-gitea#30342)
  Performance optimization for git push (go-gitea#30104)
  Reduce checkbox size to 15px (go-gitea#30346)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/gitea-actions related to the actions of Gitea type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants