Add a basic SMF manifest for SunOS platforms #4238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4238 +/- ##
=======================================
Coverage 20.09% 20.09%
=======================================
Files 153 153
Lines 30696 30696
=======================================
Hits 6168 6168
Misses 23586 23586
Partials 942 942Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lafriks
approved these changes
Jun 19, 2018
bkcsoft
added
lgtm/need 1
lafriks
added
topic/deployment
type/docs
tonivj5
approved these changes
Jun 19, 2018
|
Nice, that saves me the effort of writing one. This one works perfectly on SmartOS. |
|
@sjorge I've also made a port in pkgsrc WIP :-) |
sapk
approved these changes
Jun 24, 2018
bkcsoft
added
lgtm/done
techknowlogick
requested changes
Jun 24, 2018
contrib/init/sunos/gitea.xml
Outdated
|
|
||
| <template> | ||
| <common_name> | ||
| <loctext xml:lang="C">Compact self-hosted GIT service</loctext> |
There was a problem hiding this comment.
Can you use "A painless, self-hosted Git service" instead? It is the tagline for Gitea
Signed-off-by: Antonio Huete Jimenez <tuxillo@quantumachine.net>
|
@tuxillo nice, I could not find it on the joyent/pkgsrc-wip repo though? |
|
@techknowlogick need your approval |
|
@sjorge it's in pkgsrc-wip (NetBSD/pkgsrc-wip@6f84130) |
techknowlogick
approved these changes
Jun 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
A basic SMF file which might come handy for people use SunOS platforms like SmartOS, OmniOS, etc.
Regards,
Antonio Huete