Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping IE 11 support #6147

Closed
silverwind opened this issue Feb 21, 2019 · 8 comments · Fixed by #11470
Closed

Consider dropping IE 11 support #6147

silverwind opened this issue Feb 21, 2019 · 8 comments · Fixed by #11470
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.13.0

Comments

@silverwind
Copy link
Member

silverwind commented Feb 21, 2019 •
edited
Loading

This came up in #6139.

In my opinion it's time we drop IE11 support. It's cumbersome to test on for non-Windows users and has a ton of weird bugs that are never going to be fixed. I think we should put a statement to only support modern (evergreen) browsers.

Do we have any statistics how many users use IE on the gitea website?
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 21, 2019
@sondr3
Copy link
Contributor

sondr3 commented Feb 21, 2019

This gets a big thumbs up from me as well, Microsoft is all in on the new version of Edge running Blink and IE11 will only get fixes for very serious issues, it's about as dead in the water as it gets. Furthermore, I would be very surprised if the kind of people who use Gitea are also the same kind of people who use IE11.

@techknowlogick
Copy link
Member

techknowlogick commented Feb 21, 2019 •
edited
Loading

@sondr3 sadly I am one of those people who are required to use IE11 some of the time.

Also there are no analytics being collected on the main site.

Edit: I do recognize I am in the minority and so I won’t be a blocker to dropping support

@silverwind
Copy link
Member Author

Windows 7 will EOL in around 11 months and from that point on, the only "supported" remaining version will be on Windows 10 LTSB. A shame really that MS does not seem to intend to kill it off entirely.

@0x5c
Copy link
Contributor

0x5c commented Feb 22, 2019

Seems to me like breaking compatibility to make a statement should be avoided. However, if maintaining said compatibility actively hinders the development of gitea, then it it should be considered.

@silverwind
Copy link
Member Author

Also notable: GitHub also no longer supports IE11.

@silverwind silverwind mentioned this issue Jun 29, 2019
Merged
@silverwind silverwind mentioned this issue Aug 3, 2019
Closed
silverwind added a commit to silverwind/gitea that referenced this issue Aug 3, 2019
@silverwind
Use a web worker for syntax highlighting, drop IE11 support
ababfbf 
Syntax highlighting is now done in a separate thread which should help
performance on large files.

The web worker is initialized from a function which is not something
IE11 supports and which would force us to create a separate .js file
for the worker code.

For the reason above, I think it's a good opportunity to end IE11 support
with this commit, so it should be landed in the next minor release
version.

The code uses various ES2017 features and should work in all evergreen
browsers.

Fixes: go-gitea#6147
@silverwind silverwind mentioned this issue Oct 9, 2019
Merged
@silverwind
Copy link
Member Author

I think it's time we do this in the next major version (1.13).

@silverwind silverwind mentioned this issue Apr 11, 2020
Closed
@6543
Copy link
Member

6543 commented Apr 14, 2020 •
edited
Loading

I think we can put it to milestone 1.13.0 ?

@lafriks lafriks added this to the 1.13.0 milestone Apr 15, 2020
@silverwind
Copy link
Member Author

Indeed, 1.13 was my plan too.

@altinnadmin altinnadmin mentioned this issue May 15, 2020
Closed
@silverwind silverwind mentioned this issue May 17, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this issue May 17, 2020
@silverwind
Remove IE11 support
b21ad9b 
With master now on 1.13, it's time to drop IE11 for good. The woff
variants are also in use by Opera Mini but it has even less market share
and I can only imagine how broken the UI is in it.

Fixes: go-gitea#6147
techknowlogick added a commit that referenced this issue May 20, 2020
@silverwind @techknowlogick
Remove IE11 support (#11470)
34e6a4e 
* Remove IE11 support

With master now on 1.13, it's time to drop IE11 for good. The woff
variants are also in use by Opera Mini but it has even less market share
and I can only imagine how broken the UI is in it.

Fixes: #6147

* update docs

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@snyk-bot snyk-bot mentioned this issue Jul 10, 2020
Open
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@silverwind @techknowlogick
Remove IE11 support (go-gitea#11470)
d26c1d9 
* Remove IE11 support

With master now on 1.13, it's time to drop IE11 for good. The woff
variants are also in use by Opera Mini but it has even less market share
and I can only imagine how broken the UI is in it.

Fixes: go-gitea#6147

* update docs

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.13.0
7 participants
@lunny @silverwind @techknowlogick @lafriks @sondr3 @0x5c @6543