Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git command line commitgraph support global default true when git version >= 2.18 #7313

Merged
merged 3 commits into from
Jun 29, 2019
Merged

Add git command line commitgraph support global default true when git version >= 2.18 #7313

merged 3 commits into from
Jun 29, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 27, 2019

As title.

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 27, 2019
@lunny lunny changed the title Add commitgraph support global default true when git version >= 2.18 Add git command line commitgraph support global default true when git version >= 2.18 Jun 27, 2019
@codecov-io
Copy link

codecov-io commented Jun 27, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@37b6ee1). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7313   +/-   ##
=========================================
  Coverage          ?   41.24%           
=========================================
  Files             ?      464           
  Lines             ?    62876           
  Branches          ?        0           
=========================================
  Hits              ?    25933           
  Misses            ?    33549           
  Partials          ?     3394
Impacted Files Coverage Δ
modules/git/git.go 34.66% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b6ee1...4b2c2a9. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 27, 2019
@filipnavara filipnavara mentioned this pull request Jun 27, 2019
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 27, 2019
@zeripath
Copy link
Contributor

It would be good if we could just get go-git to create these for us.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 27, 2019
@lunny
Copy link
Member Author

lunny commented Jun 27, 2019

We can do append write to commitgraph file on post-receive. This PR only let git command read commitgraph if exist and write commitgraph when gc.

@zeripath zeripath added this to the 1.9.0 milestone Jun 29, 2019
@zeripath zeripath merged commit d741316 into go-gitea:master Jun 29, 2019
@lunny lunny deleted the lunny/add_commit_graph_true branch June 29, 2019 13:28
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
add commitgraph support global default true when git version >= 2.18 (g…
b9b4409 
…o-gitea#7313)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @zeripath @sapk @GiteaBot