Fix escaping for Makefile under Windows

[guillep2k]

Uses different find \( and \) escaping for Windows and Linux.

[jolheiser]

I felt a need to make this joke a second time.

Gitea is a self-hosted Git service written in Makefile

[silverwind]

This does break it on Cygwin for me

/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `find . -type d \\( -path ./node_modules -o -path ./docs -o -path ./public -o -path ./options -o -path ./contrib -o -path ./data \\) -prune -o -type f -name '*.go' -print'

[silverwind]

Need something better to not break Cygwin.

[silverwind]

@jolheiser what exact environment are you running in?

[guillep2k]

@jolheiser @silverwind Could you both try with this, please?:

GO_SOURCES ?= $(shell find . -type d '(' -path ./node_modules -o -path ./docs -o -path ./public -o -path ./options -o -path ./contrib -o -path ./data ')' -prune -o -type f -name
 '*.go' -print)

[silverwind]

@jolheiser @silverwind Could you both try with this, please?:

Yes, it appears '(' works on Cygwin.

[jolheiser]

@silverwind I run on Windows 10, Git Bash using MINGW64.

And '(' doesn't work in it, either.

[silverwind]

I'll try this in Git Bash.

[jolheiser]

🙇

[silverwind]

Looks like macOS find does not know -regextype, checking...

[silverwind]

@guillep2k we need one more change for Darwin and BSD which do not know the -regextype option, but do know -E:

     -E      Interpret regular expressions followed by -regex and -iregex
             primaries as extended (modern) regular expressions rather than
             basic regular expressions (BRE's).  The re_format(7) manual page
             fully describes both formats.

So for Darwin/BSD (-E before path is required):

find -E . -regex '\./(node_modules|docs|public|options|contrib|data)' -prune -o -name "*.go" -type f -print

And all others:

find . -regextype posix-egrep -regex '\./(node_modules|docs|public|options|contrib|data)' -prune -o -name "*.go" -type f -print

I guess we can do something similar to the SED_INPLACE, like FIND_REGEX.