Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to display STL preview #11181

Merged
merged 6 commits into from
Apr 22, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Apr 22, 2020

It use https://jinjunho.github.io/Madeleine.js/ to display STL files.
This lib is not the most featured but it is just what needed to preview a STL file.

Render:
image

Related: #5979

@sapk sapk added the type/docs This PR mainly updates/creates documentation label Apr 22, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 22, 2020
@sapk
Copy link
Member Author

sapk commented Apr 22, 2020

Futhermore the same logic could be used with other file format to replace "View raw" link with a js render.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 22, 2020
@lafriks lafriks merged commit 316db0f into go-gitea:master Apr 22, 2020
@sapk sapk deleted the docs-view-stl branch April 22, 2020 18:05
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Update customizing-gitea.en-us.md

* Update customizing-gitea.en-us.md

* only load assets when needed

* remove useless var

* fix missing 'i' modifier
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants