Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect on changed user and org name #11649

Merged
merged 26 commits into from
Jan 24, 2021
Merged

Redirect on changed user and org name #11649

merged 26 commits into from
Jan 24, 2021

Conversation

AndrewBezold
Copy link
Contributor

After a user's or organization's name is changed, redirect the old name to the new name until a new user/org is created with the old name.

Similar to #807

Fix #9531

@lafriks
Copy link
Member

lafriks commented May 28, 2020

Do not change translation files except English, Drone CI will take care of it when merged

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2020
@lafriks lafriks added the type/enhancement An improvement of existing functionality label May 28, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 28, 2020
CirnoT
CirnoT reviewed Jun 9, 2020
View reviewed changes
models/user.go Show resolved Hide resolved
CirnoT
CirnoT reviewed Jun 9, 2020
View reviewed changes
routers/repo/http.go Outdated Show resolved Hide resolved
routers/repo/repo.go Outdated Show resolved Hide resolved
options/locale/locale_en-US.ini Show resolved Hide resolved
templates/org/settings/options.tmpl Show resolved Hide resolved
templates/user/settings/profile.tmpl Show resolved Hide resolved
@CirnoT
Copy link
Contributor

CirnoT commented Jun 10, 2020

Should we perhaps redirect only repositories like GitHub does? Currently I see that it also redirect on user profile.

chrome_2020-06-10_08-51-27

@CirnoT
Copy link
Contributor

CirnoT commented Jun 10, 2020

In addition I would definitely add logic like GitHub has where notice is printed about new link on Git action.

@AndrewBezold
Copy link
Contributor Author

Should we perhaps redirect only repositories like GitHub does? Currently I see that it also redirect on user profile.

chrome_2020-06-10_08-51-27

I see now how Github does it. I guess the question would be then, do we want to match Github, or do we want to have more features? Do you see any major issues for this that wouldn't arise for repository redirects?

@CirnoT
Copy link
Contributor

CirnoT commented Jun 15, 2020 •
edited
Loading

No specific security concerns that I can think of.

The only reason i could think of not to do it would be making others aware quicker that name has changed. I'm not particularly set on either way, just a random thought I had; treat it more as open discussion rather than blocking issue.

@stale
Copy link

stale bot commented Aug 16, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 16, 2020
@6543
Copy link
Member

6543 commented Aug 16, 2020

@AndrewBezold whats the state?

@stale stale bot removed the issue/stale label Aug 16, 2020
@lunny lunny modified the milestones: 1.13.0, 1.14.0 Sep 10, 2020
@stale
Copy link

stale bot commented Nov 9, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 9, 2020
6543
6543 reviewed Jan 23, 2021
View reviewed changes
models/user.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 23, 2021
@6543 6543 mentioned this pull request Jan 23, 2021
Closed
@6543
Copy link
Member

6543 commented Jan 23, 2021

@zeripath ping ;)

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 23, 2021
zeripath
zeripath reviewed Jan 23, 2021
View reviewed changes
models/user.go Outdated Show resolved Hide resolved
6543
6543 reviewed Jan 23, 2021
View reviewed changes
models/user.go Outdated Show resolved Hide resolved
@6543
Copy link
Member

6543 commented Jan 24, 2021

@zeripath ☝️

zeripath
zeripath reviewed Jan 24, 2021
View reviewed changes
models/user.go Outdated Show resolved Hide resolved
@6543 @zeripath
Update models/user.go
f11bb7e 
Co-authored-by: zeripath <art27@cantab.net>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 24, 2021
@6543
Copy link
Member

6543 commented Jan 24, 2021

🚀

@6543 6543 merged commit bc05ddc into go-gitea:master Jan 24, 2021
@6543 6543 mentioned this pull request Jan 24, 2021
Merged
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 25, 2021
@a1012112796
Merge branch 'master' into feature/dismissing_reviews
c599356 
* master: (358 commits)
  [skip ci] Updated translations via Crowdin
  Use caddy's certmagic library for extensible/robust ACME handling (go-gitea#14177)
  Redirect on changed user and org name (go-gitea#11649)
  chore: bump minio to RELEASE.2021-01-16T02-19-44Z (go-gitea#14445)
  [skip ci] Updated translations via Crowdin
  CI: skip build steps for cron update works (go-gitea#14443)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  just overload to not get it by mistake again ... (go-gitea#14440)
  [skip ci] Updated translations via Crowdin
  Add link to packages in openSUSE build service (go-gitea#14439)
  Improve Description in new/ edit Project template (go-gitea#14429)
  Don't show "Reference in new issue" when issues unit is globally disabled (go-gitea#14437)
  CI: Update license & gitignore by cron (go-gitea#14419)
  Fix close/reopen with comment (go-gitea#14436)
  Add german translation guidelines (go-gitea#14283)
  [skip ci] Updated translations via Crowdin
  Fix lfs preview bug (go-gitea#14428)
  [skip ci] Updated translations via Crowdin
  Bump gsap from 3.5.1 to 3.6.0 (go-gitea#14410)
  ...
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 25, 2021
@a1012112796
Merge branch 'master' into empty_pr
7863e53 
* master: (542 commits)
  [skip ci] Updated translations via Crowdin
  Use caddy's certmagic library for extensible/robust ACME handling (go-gitea#14177)
  Redirect on changed user and org name (go-gitea#11649)
  chore: bump minio to RELEASE.2021-01-16T02-19-44Z (go-gitea#14445)
  [skip ci] Updated translations via Crowdin
  CI: skip build steps for cron update works (go-gitea#14443)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  just overload to not get it by mistake again ... (go-gitea#14440)
  [skip ci] Updated translations via Crowdin
  Add link to packages in openSUSE build service (go-gitea#14439)
  Improve Description in new/ edit Project template (go-gitea#14429)
  Don't show "Reference in new issue" when issues unit is globally disabled (go-gitea#14437)
  CI: Update license & gitignore by cron (go-gitea#14419)
  Fix close/reopen with comment (go-gitea#14436)
  Add german translation guidelines (go-gitea#14283)
  [skip ci] Updated translations via Crowdin
  Fix lfs preview bug (go-gitea#14428)
  [skip ci] Updated translations via Crowdin
  Bump gsap from 3.5.1 to 3.6.0 (go-gitea#14410)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CirnoT CirnoT CirnoT left review comments

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Redirect on changing user and organization name
8 participants
@AndrewBezold @lafriks @CirnoT @6543 @codecov-io @zeripath @lunny @GiteaBot