UI: Fix input field border size for filter button in green theme #12491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xMasterX
changed the title
Codecov Report
@@ Coverage Diff @@
## master #12491 +/- ##
==========================================
+ Coverage 43.74% 43.75% +0.01%
==========================================
Files 631 631
Lines 69870 69870
==========================================
+ Hits 30565 30572 +7
+ Misses 34348 34345 -3
+ Partials 4957 4953 -4
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
silverwind
approved these changes
Aug 14, 2020
GiteaBot
added
lgtm/need 1
|
Just playing around with this in the devtools, I think we still need to handle the focus style:
Generally I suggest not setting a |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Oct 19, 2020
- Style search dropdown - Fix radio buttons and tweak checkboxes - Add styling for error form elements - Make borders brighter and focus more apparent - Adjust comment box border color to match Fixes: go-gitea#12491
techknowlogick
added a commit
that referenced
this pull request
Oct 20, 2020
- Style search dropdown - Fix radio buttons and tweak checkboxes - Add styling for error form elements - Make borders brighter and focus more apparent - Adjust comment box border color to match Fixes: #12491 Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 20, 2020
- Style search dropdown - Fix radio buttons and tweak checkboxes - Add styling for error form elements - Make borders brighter and focus more apparent - Adjust comment box border color to match Fixes: go-gitea#12491 Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick
added a commit
that referenced
this pull request
Oct 20, 2020
- Style search dropdown - Fix radio buttons and tweak checkboxes - Add styling for error form elements - Make borders brighter and focus more apparent - Adjust comment box border color to match Fixes: #12491 Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes wrong size of input field
Before:
After:
