Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go1.15 on windows #12589

Merged
merged 2 commits into from
Aug 24, 2020
Merged

go1.15 on windows #12589

merged 2 commits into from
Aug 24, 2020

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Aug 24, 2020 •
edited
Loading

fix #12588

related: golang/go#40795

@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 24, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Aug 24, 2020
@techknowlogick
Copy link
Member Author

@iamdoubz I tested this on a windows machine I had access to, but could you also try on yours?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 24, 2020
silverwind
silverwind reviewed Aug 24, 2020
View reviewed changes
.drone.yml Show resolved Hide resolved
@iamdoubz
Copy link

This patch worked for 1.13 building on Windows.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 24, 2020
@techknowlogick techknowlogick merged commit 125ffb8 into go-gitea:master Aug 24, 2020
@techknowlogick techknowlogick deleted the go1.15windows branch August 24, 2020 21:46
techknowlogick added a commit that referenced this pull request Aug 24, 2020
@techknowlogick
go1.15 on windows (#12589)
6743f8a 
We don't support go1.15 on 1.12.x branch, however this will allow users who chose to build with go1.15 on windows to be sucessful
@techknowlogick techknowlogick mentioned this pull request Aug 24, 2020
Merged
techknowlogick added a commit that referenced this pull request Aug 24, 2020
@techknowlogick
go1.15 on windows (#12589) (#12593)
cfbfb73 
We don't support go1.15 on 1.12.x branch, however this will allow users who chose to build with go1.15 on windows to be successful
@zeripath zeripath added the backport/done All backports for this PR have been created label Sep 15, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

Unable to compile on windows using Go 1.15
5 participants
@techknowlogick @iamdoubz @silverwind @zeripath @GiteaBot