Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case typo #13049

Merged
merged 2 commits into from Oct 6, 2020
Merged

fix: case typo #13049

merged 2 commits into from Oct 6, 2020

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Oct 6, 2020

No description provided.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 6, 2020
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Oct 6, 2020
@techknowlogick
Copy link
Member

please run make generate-swagger

@pd4d10
Copy link
Contributor Author

pd4d10 commented Oct 6, 2020

@techknowlogick Done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #13049 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13049      +/-   ##
==========================================
+ Coverage   42.49%   42.60%   +0.11%     
==========================================
  Files         672      672              
  Lines       73785    73785              
==========================================
+ Hits        31353    31436      +83     
+ Misses      37361    37256     -105     
- Partials     5071     5093      +22     
Impacted Files Coverage Δ
routers/api/v1/settings/settings.go 100.00% <ø> (ø)
modules/queue/workerpool.go 58.77% <0.00%> (-2.05%) ⬇️
modules/log/event.go 57.54% <0.00%> (-0.95%) ⬇️
models/repo_list.go 78.57% <0.00%> (-0.90%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
services/mailer/mail.go 55.91% <0.00%> (+1.07%) ⬆️
modules/notification/notification.go 81.25% <0.00%> (+2.67%) ⬆️
modules/notification/base/null.go 71.42% <0.00%> (+2.85%) ⬆️
modules/git/commit.go 54.72% <0.00%> (+4.05%) ⬆️
modules/notification/mail/mail.go 34.48% <0.00%> (+5.74%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eea301...852ba0f. Read the comment docs.

@techknowlogick
Copy link
Member

@pd4d10 could you mark your PRs as allow edits from maintainers, as we need to be able to rebase and squash changes before merging

@pd4d10
Copy link
Contributor Author

pd4d10 commented Oct 6, 2020

@techknowlogick It seems to be caused by the organization fork. I'll try to send another PR from my personal account's fork.

https://github.community/t/how-can-we-enable-allow-edits-from-maintainers-by-default/2847

@techknowlogick
Copy link
Member

@pd4d10 No need to send another PR I'll use my admin override

@techknowlogick techknowlogick merged commit 77f360b into go-gitea:master Oct 6, 2020
@pd4d10 pd4d10 deleted the patch-2 branch October 6, 2020 16:17
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants