Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from com.* to alternatives #14103

Merged
merged 12 commits into from
Dec 25, 2020
Merged

migrate from com.* to alternatives #14103

merged 12 commits into from
Dec 25, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 22, 2020

migrate more com functions to util or replace with fmt replacements ...

  • avoid reflections
  • report errors

cc @lunny

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 22, 2020
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 22, 2020
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 22, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 22, 2020
@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #14103 (4211fb8) into master (f6bec85) will decrease coverage by 0.00%.
The diff coverage is 27.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14103      +/-   ##
==========================================
- Coverage   42.34%   42.34%   -0.01%     
==========================================
  Files         726      727       +1     
  Lines       77819    77860      +41     
==========================================
+ Hits        32952    32969      +17     
- Misses      39452    39473      +21     
- Partials     5415     5418       +3     
Impacted Files Coverage Δ
cmd/serv.go 2.63% <0.00%> (-0.04%) ⬇️
models/branches.go 41.36% <0.00%> (ø)
models/issue_xref.go 61.22% <0.00%> (ø)
models/repo_unit.go 86.48% <0.00%> (ø)
models/user.go 54.40% <0.00%> (ø)
modules/git/repo.go 42.77% <0.00%> (-0.76%) ⬇️
routers/admin/auths.go 35.44% <0.00%> (ø)
routers/admin/emails.go 0.00% <0.00%> (ø)
routers/admin/notice.go 0.00% <0.00%> (ø)
routers/api/v1/utils/hook.go 0.00% <0.00%> (ø)
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd607b5...4211fb8. Read the comment docs.

modules/base/tool.go Outdated Show resolved Hide resolved
modules/util/copy.go Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Dec 22, 2020

migrate more com functions to util or replace with fmt replacements ...

  • avoid reflections
  • report errors

cc @lunny

Thanks for your hardworking. I sent a nit change request, otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 22, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 25, 2020
@lafriks lafriks merged commit a19447a into go-gitea:master Dec 25, 2020
@lafriks lafriks deleted the rm-com branch December 25, 2020 09:59
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants