Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self from MAINTAINERS #14286

Merged
merged 3 commits into from
Jan 9, 2021
Merged

Remove self from MAINTAINERS #14286

merged 3 commits into from
Jan 9, 2021

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Jan 8, 2021 •
edited
Loading

My time is limited and in subsequent months will become even more so. Given that fact and recent developments, I don't think I want (or will be able, in near future) to dedicate any more of my time as maintainer of this project.

@CirnoT
Remove self from MAINTAINERS
d85b1a7 
My time is limited and given recent developments, I don't think i want to dedicate any more of my time to this project.
@codecov-io
Copy link

codecov-io commented Jan 8, 2021 •
edited
Loading

Codecov Report

Merging #14286 (7a7c0c7) into master (bcb7f35) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14286      +/-   ##
==========================================
- Coverage   41.78%   41.76%   -0.02%     
==========================================
  Files         743      743              
  Lines       79461    79461              
==========================================
- Hits        33199    33190       -9     
- Misses      40795    40804       +9     
  Partials     5467     5467
Impacted Files Coverage Δ
modules/git/repo_base_nogogit.go 63.63% <0.00%> (-9.10%) ⬇️
modules/indexer/stats/db.go 48.00% <0.00%> (-8.00%) ⬇️
modules/git/utils.go 77.77% <0.00%> (-2.78%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
services/pull/check.go 48.52% <0.00%> (-0.74%) ⬇️
routers/repo/view.go 37.60% <0.00%> (-0.65%) ⬇️
services/pull/pull.go 42.57% <0.00%> (ø)
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb7f35...7a7c0c7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2021
lunny
lunny approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your ideas and contributions for Gitea as a maintainer. Although some of them are not comfortable, I think most of them are meaningful to Gitea.
Thanks again and wish you could continue to contribute to Gitea.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2021
6543
6543 approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the time you spent

I wish you the best 👋

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 8, 2021
@lafriks
Copy link
Member

lafriks commented Jan 8, 2021 •
edited
Loading

Thanks for all your contributions! Hope to see you back 😉

@a1012112796
Copy link
Member

a1012112796 commented Jan 8, 2021 •
edited
Loading

Hello. Thanks for all your contributions!But I don't think it's necessary to chage this file. it just a history file. follow CONTRIBUTING file, I think just please owner move you to @go-gitea/advisors team is enough. do you think so? thanks

@techknowlogick techknowlogick merged commit 7369282 into go-gitea:master Jan 9, 2021
@gsantner
Copy link

gsantner commented Jan 9, 2021

Given that fact and recent developments, I don't think I want

Curious, whats going on? I mean there are sometimes things that break due merges, and maybe some bloat/features-creep, but otherwise seems quite fine. Whats up in the project recently?

@CirnoT
Copy link
Contributor Author

CirnoT commented Jan 9, 2021

Given that fact and recent developments, I don't think I want

Curious, whats going on? I mean there are sometimes things that break due merges, and maybe some bloat/features-creep, but otherwise seems quite fine. Whats up in the project recently?

Nothing relevant to users overall, please don't worry.

@CirnoT CirnoT deleted the patch-1 branch January 9, 2021 14:24
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 14, 2021
@a1012112796
Merge branch 'master' into imap
77cedeb 
* master: (252 commits)
  Issues overview should not show issues from archived repos (go-gitea#13220)
  Display SVG files as images instead of text (go-gitea#14101)
  [skip ci] Updated translations via Crowdin
  Update docs to clarify issues raised in go-gitea#14272 (go-gitea#14318)
  [skip ci] Updated translations via Crowdin
  [Refactor] Passwort Hash/Set (go-gitea#14282)
  Add option to change username to the admin panel (go-gitea#14229)
  fix mailIssueCommentBatch for pull request (go-gitea#14252)
  Remove self from MAINTAINERS (go-gitea#14286)
  Do not reload page after adding comments in Pull Request reviews (go-gitea#13877)
  Fix session bug when introduce chi (go-gitea#14287)
  [skip ci] Updated translations via Crowdin
  Add secure/httpOnly attributes to the lang cookie (go-gitea#9690) (go-gitea#14279)
  Some code improvements (go-gitea#14266)
  [skip ci] Updated translations via Crowdin
  Fix wrong type on hooktask to convert typ from char(16) to varchar(16) (go-gitea#14148)
  Upgrade XORM links in documentation. (go-gitea#14265)
  Check permission for the appropriate unit type (go-gitea#14261)
  Add compliance check for windows to ensure cross platform build (go-gitea#14260)
  [skip ci] Updated translations via Crowdin
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@CirnoT @codecov-io @lafriks @a1012112796 @gsantner @lunny @6543 @techknowlogick @GiteaBot