Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Add pagination to ListBranches #14524

Merged
merged 16 commits into from
Feb 3, 2021
Merged

[API] Add pagination to ListBranches #14524

merged 16 commits into from
Feb 3, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 30, 2021 •
edited
Loading

as title followup of #14202 for api & ui ...

add pagination to GetBranches-git-backend

@6543 6543 added this to the 1.14.0 milestone Jan 30, 2021
@6543 6543 added modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality labels Jan 30, 2021
6543
6543 commented Jan 30, 2021
View reviewed changes
routers/api/v1/utils/utils.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 30, 2021
@6543 6543 force-pushed the api-ListBranches_add-pagination branch from d9a7173 to aa7e795 Compare February 2, 2021 00:07
zeripath
zeripath reviewed Feb 2, 2021
View reviewed changes
routers/repo/branch.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Feb 2, 2021
View reviewed changes
routers/repo/branch.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Feb 2, 2021
View reviewed changes
routers/repo/branch.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Feb 2, 2021
View reviewed changes
routers/repo/branch.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Feb 2, 2021
View reviewed changes
routers/repo/branch.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Feb 2, 2021
View reviewed changes
routers/repo/branch.go Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Feb 2, 2021
View reviewed changes
routers/repo/branch.go Outdated Show resolved Hide resolved
6543 and others added 2 commits February 2, 2021 20:37
@6543 @zeripath
Update routers/repo/branch.go
0637264 
Co-authored-by: zeripath <art27@cantab.net>
@6543
update desc
8f70491
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 3, 2021
@lunny
Copy link
Member

lunny commented Feb 3, 2021

util, helper and etc package names should be depreciated.

@6543 6543 mentioned this pull request Feb 3, 2021
Closed
@6543 6543 merged commit 0d14447 into go-gitea:master Feb 3, 2021
@6543 6543 deleted the api-ListBranches_add-pagination branch February 3, 2021 19:06
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @zeripath @a1012112796 @GiteaBot