Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue/pull sidebar #14826

Merged
merged 5 commits into from
Feb 28, 2021
Merged

Fix issue/pull sidebar #14826

merged 5 commits into from
Feb 28, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 27, 2021 •
edited
Loading

Close #14825

@6543 6543 changed the title fix #14719 WIP: fix #14719 Feb 27, 2021
@6543 6543 changed the title WIP: fix #14719 Fix issue/pull sidebar Feb 28, 2021
@6543 6543 added type/bug topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 28, 2021
@6543 6543 added this to the 1.14.0 milestone Feb 28, 2021
@6543 6543 mentioned this pull request Feb 28, 2021
Closed
@codecov-io
Copy link

Codecov Report

Merging #14826 (6a4a622) into master (487f2ee) will increase coverage by 0.01%.
The diff coverage is 42.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14826      +/-   ##
==========================================
+ Coverage   42.21%   42.22%   +0.01%     
==========================================
  Files         767      771       +4     
  Lines       81624    82181     +557     
==========================================
+ Hits        34458    34702     +244     
- Misses      41531    41827     +296     
- Partials     5635     5652      +17
Impacted Files Coverage Δ
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/oauth2.go 29.16% <0.00%> (-2.66%) ⬇️
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 65.22% <0.00%> (+6.72%) ⬆️
modules/indexer/code/elastic_search.go 1.72% <0.00%> (-0.02%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7e3bd...6a4a622. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 28, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2021
@6543
Copy link
Member Author

6543 commented Feb 28, 2021

🚀

@6543 6543 merged commit dc08195 into go-gitea:master Feb 28, 2021
@6543 6543 deleted the fix_sidebar.tmpl branch February 28, 2021 14:05
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@noerw noerw noerw approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Footer broken when disabling dependencies
5 participants
@6543 @codecov-io @zeripath @noerw @GiteaBot