-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable listing of forks when logged out #14992
Re-enable listing of forks when logged out #14992
Conversation
ef7b6cb
to
26d5028
Compare
|
Codecov Report
@@ Coverage Diff @@
## master #14992 +/- ##
==========================================
+ Coverage 42.21% 42.25% +0.04%
==========================================
Files 767 774 +7
Lines 81624 82994 +1370
==========================================
+ Hits 34458 35073 +615
- Misses 41531 42224 +693
- Partials 5635 5697 +62
Continue to review full report at Codecov.
|
The second commit is admittedly a bit hacky, for enabling cursor events from outside ( This revision would ensure that:
I personally find the low opacity a bit intimidating, but probably that's just me. |
This PR addresses point 1 of #14926 further by further aligning the look-and-feel of the fork button to that of the other buttons.
When hovering above the fork button, a guest user will still be prompted to log in, but no action is performed on mouse click, exactly like the other two buttons. The user will still be able to list forks when logged out.