Systemd needs After as well as Require #15881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the gitea service is stopped because of the db going down it needs an `After=db.service` to ensure it is restarted in addition to the `Requires=db.service` to ensure that the db is started before gitea is started. Fix go-gitea#15866 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## main #15881 +/- ##
=======================================
Coverage 44.01% 44.02%
=======================================
Files 681 681
Lines 82333 82333
=======================================
+ Hits 36241 36244 +3
+ Misses 40189 40188 -1
+ Partials 5903 5901 -2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
This doesn't fix it for me. I'll wait to see how it behaves with unattended upgrades, but when doing the following manually gitea doesn't come up again: |
lafriks
approved these changes
May 15, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 16, 2021
GiteaBot
added
lgtm/done
|
@lafriks @lunny soo.. your approvals mean that you couldn't reproduce what I described in #15881 (comment)? |
Sorry, haven't noticed your reply. I haven't tested it in a real test environment just think it's right in theory and maybe it hasn't fixed #15866 so we can reopen it. |
lafriks
added
the
skip-changelog
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
If the gitea service is stopped because of the db going down it needs an `After=db.service` to ensure it is restarted in addition to the `Requires=db.service` to ensure that the db is started before gitea is started. Fix go-gitea#15866 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Gitea service is stopped because of the db going down
it needs an
After=db.serviceto ensure it is restarted inaddition to the
Requires=db.serviceto ensure that the dbis started before Gitea is started.
Fix #15866
Signed-off-by: Andrew Thornton art27@cantab.net