Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mkdir jwt - permission denied #16227

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Fix mkdir jwt - permission denied #16227

merged 2 commits into from
Jun 23, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jun 22, 2021 •
edited by zeripath
Loading

The JWT certificate is now expected in the data directory. That's the same the ssh part does.

Ref #16010
Fixes #16218

@KN4CK3R KN4CK3R added this to the 1.15.0 milestone Jun 22, 2021
@zeripath
Copy link
Contributor

This is a difficult one because the other certificates are based in the custom directory too.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 22, 2021
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Jun 22, 2021

Personally I don't like that Gitea generates secrets if they are missing. If the user configured something which needs another setting it should just fail. In case of the JWT part it should not fallback to another hashing algorithm too.
The HTTPS and mail certificate are expected in the conf directory (not generated by Gitea). The SSH certificate is expected in the data directory (generated by Gitea) (maybe because of the same reason?).

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 22, 2021
@zeripath
Copy link
Contributor

we're probably gonna have to think of some way of migrating current users to the new form.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 23, 2021
@6543
Copy link
Member

6543 commented Jun 23, 2021

🚀

@6543 6543 merged commit 31f6b95 into go-gitea:main Jun 23, 2021
@KN4CK3R KN4CK3R deleted the fix-16218 branch June 23, 2021 22:25
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 27, 2021
@zeripath zeripath mentioned this pull request Jun 27, 2021
Merged
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@KN4CK3R @AbdulrhmnGhanem
Use data path instead of config path (go-gitea#16227)
0c1ff24
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

[Bug] - mkdir jwt - permission denied
4 participants
@KN4CK3R @zeripath @6543 @GiteaBot