-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use github token URL when fetching oauth token #16709
Merged
zeripath
merged 3 commits into
go-gitea:main
from
techknowlogick:techknowlogick-patch-3
Aug 17, 2021
Merged
use github token URL when fetching oauth token #16709
zeripath
merged 3 commits into
go-gitea:main
from
techknowlogick:techknowlogick-patch-3
Aug 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
type/bug
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
labels
Aug 16, 2021
Codecov Report
@@ Coverage Diff @@
## main #16709 +/- ##
==========================================
+ Coverage 45.38% 45.41% +0.03%
==========================================
Files 758 758
Lines 85306 85306
==========================================
+ Hits 38713 38741 +28
+ Misses 40313 40286 -27
+ Partials 6280 6279 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Aug 17, 2021
jolheiser
approved these changes
Aug 17, 2021
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Aug 17, 2021
KN4CK3R
approved these changes
Aug 17, 2021
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 17, 2021
lafriks
approved these changes
Aug 17, 2021
zeripath
approved these changes
Aug 17, 2021
zeripath
added
the
issue/regression
Issue needs no code to be fixed, only a description on how to fix it yourself
label
Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
issue/regression
Issue needs no code to be fixed, only a description on how to fix it yourself
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression in #16544 whereby the default token url
for github was changed to the gitea one.