Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate releases page & set default page size to 10 #16857

Merged
merged 3 commits into from
Aug 29, 2021
Merged

Paginate releases page & set default page size to 10 #16857

merged 3 commits into from
Aug 29, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 29, 2021 •
edited by zeripath
Loading

Reduce the number of releases shown on the releases page from 30 to 10 and add paging.

⚠️ BREAKING ⚠️

Users may change the default value by setting

[repository.release]
DEFAULT_PAGING_NUM=10

@lunny lunny added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Aug 29, 2021
@lunny lunny added this to the 1.16.0 milestone Aug 29, 2021
6543
6543 reviewed Aug 29, 2021
View reviewed changes
routers/web/repo/release.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2021
6543
6543 reviewed Aug 29, 2021
View reviewed changes
routers/web/repo/release.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 29, 2021
delvh
delvh approved these changes Aug 29, 2021
View reviewed changes
Copy link
Member

@delvh delvh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind changing the title to something like Add default release pagination of 10 releases?
That way I think it would be clearer what this PR is trying to achieve.

EDIT: Thanks.

docs/content/doc/advanced/config-cheat-sheet.en-us.md Show resolved Hide resolved
@zeripath zeripath changed the title Add release default page and set it to 10 Paginate releases page & set default page size to 10 Aug 29, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 29, 2021
@6543 6543 merged commit d985d4b into go-gitea:main Aug 29, 2021
@lunny lunny deleted the lunny/reduce_release_pagesize branch August 29, 2021 16:28
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@zeripath zeripath zeripath approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @zeripath @6543 @delvh @GiteaBot