-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Discontinued) Enforce two-factor authentication #16880
Conversation
How did you control the permssion? |
I just studied the logic of And unit tests are also updated with 2FA cases. More thoughts: why are the |
This comment has been minimized.
This comment has been minimized.
Maybe we could split it as two PRs, one is always requiring login with 2FA, another is changing the runtime permissions when login with 2fa or password only. |
06b4f05
to
df179c4
Compare
There are new commits to this, is it still discontinued, or is it now a WIP? Edit: nvm. I should've read the description |
38a1d15
to
6c9926e
Compare
9c2512c
to
7c89d0f
Compare
814048d
to
68f9b59
Compare
Does this affect the first admin user registry? |
Discontinued (due to #13606 (comment)), I won't spend time on it. I am still keeping updating my 2FA branch with main branch, and I am still using it in my instance. |
86dd382
to
52b1495
Compare
# Conflicts: # templates/base/alert.tmpl
# Conflicts: # templates/status/404.tmpl
Disclaimer: Since this PR doesn't seem to be merged easily (#13606 (comment)), and much more work need to do.
I just keep this PR for my personal usage, and update it with main branch regularly.
Anyone who want to continue the work for Enforced 2FA can pick this PR or start a new one.
Design:
security.ENFORCE_TWO_FACTOR_AUTH
.