Always use git command but not os.Command #18363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
6543
approved these changes
Jan 22, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
approved these changes
Jan 22, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #18363 +/- ##
=======================================
Coverage ? 46.06%
=======================================
Files ? 838
Lines ? 92730
Branches ? 0
=======================================
Hits ? 42713
Misses ? 43233
Partials ? 6784
Continue to review full report at Codecov.
|
lunny
pushed a commit
to Gusted/gitea
that referenced
this pull request
Jan 23, 2022
- Pass the Global command args into serviceRPC. - Fixes error with partial cloning.
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Jan 23, 2022
* 'main' of https://github.com/go-gitea/gitea: Add packagist webhook (go-gitea#18224) Fix mime-type detection for HTTP server (go-gitea#18370) Always use git command but not os.Command (go-gitea#18363) Add deprecated for LFS_CONTENT_PATH on zh-cn docs (go-gitea#18362) [skip ci] Updated translations via Crowdin Make gitea, gitea-vet future-proof (go-gitea#18361) Pause queues (go-gitea#15928) Disable content sniffing on `PlainTextBytes` (go-gitea#18359) Update github.com/duo-labs/webauthn (go-gitea#18357)
zeripath
reviewed
Jan 23, 2022
| return nil, fmt.Errorf("error creating StdoutPipe: %w", err) | ||
| } | ||
| go func(ctx context.Context, diffArgs []string, repoPath string, writer *io.PipeWriter) { | ||
| cmd := git.NewCommandContextNoGlobals(ctx, diffArgs...) |
There was a problem hiding this comment.
This needs to be NewCommandContext too. no it doesn't sorry Actually I'm really not sure about this.
I have a feeling that this should be NewCommandContext and we need to create our own lfs.filter.
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.