-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial stub for custom webhooks #18748
Conversation
I expect there is a config file to add more than one custom webhook. |
Codecov Report
@@ Coverage Diff @@
## main #18748 +/- ##
==========================================
- Coverage 46.64% 46.54% -0.10%
==========================================
Files 846 853 +7
Lines 121331 122586 +1255
==========================================
+ Hits 56595 57061 +466
- Misses 57859 58637 +778
- Partials 6877 6888 +11
Continue to review full report at Codecov.
|
Something broke since I last built this, I will @ someone when its ready for review but until then this is broken. |
So if I understand this code correctly - this custom hook is essentially:
? |
One URL is required, everything else is optional. Optional headers, optional POST data, POST or GET option but right now this is to get the ball rolling. |
Could replace #18224 |
That PR has been merged. |
@@ -404,6 +404,12 @@ type NewPackagistHookForm struct { | |||
WebhookForm | |||
} | |||
|
|||
type NewCustomHookForm struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment is needed.
I thought it would be best to start making a customizable webhook instead of creating an integration for everything under the sun. We can add more optional headers as they come up?