Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use xorm builder for models.getReviewers() #19033

Merged
merged 7 commits into from
Mar 10, 2022
Merged

use xorm builder for models.getReviewers() #19033

merged 7 commits into from
Mar 10, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 8, 2022

as title

-> #19030 (comment)

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 8, 2022
@6543 6543 added this to the 1.17.0 milestone Mar 8, 2022
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 8, 2022
@6543 6543 mentioned this pull request Mar 8, 2022
Merged
@6543 6543 requested a review from noerw March 8, 2022 23:39
@6543
Copy link
Member Author

6543 commented Mar 8, 2022

... this way we could re-use the condition if needed at some point ...

and first and it should dedup code and be better redable

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 9, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@c21735b). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19033   +/-   ##
=======================================
  Coverage        ?   46.60%           
=======================================
  Files           ?      854           
  Lines           ?   122911           
  Branches        ?        0           
=======================================
  Hits            ?    57286           
  Misses          ?    58706           
  Partials        ?     6919
Impacted Files Coverage Δ
models/repo.go 54.27% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c21735b...cb894d5. Read the comment docs.

zeripath
zeripath reviewed Mar 9, 2022
View reviewed changes
models/repo.go Outdated Show resolved Hide resolved
noerw
noerw reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@noerw noerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability-wise this is a huge step backwards (at least the public repo query), so I can't really approve this. Functionality-wise this looks good.

6543 and others added 2 commits March 10, 2022 17:17
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2022
@6543 6543 merged commit ba470a8 into go-gitea:main Mar 10, 2022
@6543 6543 deleted the getReviewers_xorm.builder branch March 10, 2022 18:12
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 11, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
151563f 
* giteaofficial/main:
  Prevent 500 when there is an error during new auth source post (go-gitea#19041)
  Update the webauthn_credential_id_sequence in Postgres (go-gitea#19048)
  If rendering has failed due to a net.OpError stop rendering (attempt 2) (go-gitea#19049)
  use xorm builder for models.getReviewers() (go-gitea#19033)
  RSS/Atom support for Orgs (go-gitea#17714)
  Fix flag validation (go-gitea#19046)
  Improve SyncMirrors logging (go-gitea#19045)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@6543
use xorm builder for models.getReviewers() (go-gitea#19033)
1ebaa3c 
* xorm builder

* dedup code
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw left review comments

@zeripath zeripath zeripath left review comments

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @codecov-commenter @lunny @lafriks @zeripath @noerw @GiteaBot