Estimate Action Count in Statistics #19775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
performance/speed
GiteaBot
added
the
lgtm/need 1
delvh
reviewed
May 21, 2022
wxiaoguang
approved these changes
May 21, 2022
GiteaBot
added
lgtm/done
lunny
approved these changes
May 21, 2022
Co-authored-by: delvh <dev.lh@web.de>
Codecov Report
@@ Coverage Diff @@
## main #19775 +/- ##
=======================================
Coverage ? 47.27%
=======================================
Files ? 957
Lines ? 133339
Branches ? 0
=======================================
Hits ? 63034
Misses ? 62654
Partials ? 7651
Continue to review full report at Codecov.
|
techknowlogick
approved these changes
May 21, 2022
|
On second thoughts perhaps this shouldn't be backported. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 22, 2022
* giteaofficial/main: [skip ci] Updated licenses and gitignores Estimate Action Count in Statistics (go-gitea#19775)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
jolheiser
pushed a commit
that referenced
this pull request
Dec 30, 2022
The `EstimateCount` could be incorrect when the table lives in multiple schemas. Related to #19775.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exract from #19474
As #19474 appears completely stalled. This PR simply changes the statistic generation to only estimate counts for the Action table. I still believe that estimates would be appropriate for a number of other results - most likely the comment count.
Fix #17506
Signed-off-by: Andrew Thornton art27@cantab.net