[refactor] Use const for wiki DefaultBranch #21466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
the
type/refactoring
wxiaoguang
approved these changes
Oct 15, 2022
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Oct 15, 2022
GiteaBot
added
lgtm/done
6543
added
the
skip-changelog
|
off topic: but IMO most modern compilers support string pool optimization, then there would be only one copy of the duplicate string in binary. If Golang team is a modern team, Golang should also have such optimization. 😁 (I haven't looked into details, just a guess) |
|
yes but it make it more maintainable, and that's my main point here |
|
. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a nit, that will make it easier to change things and we now have a single source of truth