Hide target selector if tag exists when creating new release #23171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
reviewed
Mar 1, 2023
GiteaBot
added
the
lgtm/need 2
wxiaoguang
reviewed
Mar 1, 2023
Zettat123
force-pushed
the
bugfix/issue-22649
branch
from
2cdff7e
to
993d74e
Compare
lunny
approved these changes
Mar 3, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Mar 3, 2023
wxiaoguang
reviewed
Mar 3, 2023
web_src/js/index.js
Outdated
| @@ -198,4 +199,6 @@ $(document).ready(() => { | |||
| initUserAuthWebAuthnRegister(); | |||
| initUserSettings(); | |||
| initViewedCheckboxListenerFor(); | |||
|
|
|||
| initTagNameEditor(); | |||
There was a problem hiding this comment.
IMO we do not need to make more global init calls.
The tag-name-editor only appears on the repository new release page.
So the exiting initRepoReleaseEditor could be refactored to something like:
export function initRepoReleaseNew() {
const $repoReleaseNew = $('.repository.new.release');
if (!$repoReleaseNew.length) return;
// init tag name editor
// init content editor
}There was a problem hiding this comment.
Good idea. I refactored the initRepoReleaseEditor according to your comment.
silverwind
reviewed
Mar 3, 2023
silverwind
approved these changes
Mar 10, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
🎺 🤖 |
jolheiser
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 13, 2023
* giteaofficial/main: Scoped label display and documentation tweaks (go-gitea#23430) Deduplicate template code for label selection menu (go-gitea#23431) Show edit/close/delete button on organization wide repositories (go-gitea#23388) Sync the class change of Edit Column Button to JS code (go-gitea#23400) Preserve file size when creating attachments (go-gitea#23406) [skip ci] Updated translations via Crowdin Use buildkit for docker builds (go-gitea#23415) Refactor branch/tag selector dropdown (first step) (go-gitea#23394) [skip ci] Updated translations via Crowdin Hide target selector if tag exists when creating new release (go-gitea#23171) Parse external request id from request headers, and print it in access log (go-gitea#22906) Add missing tabs to org projects page (go-gitea#22705) Add user webhooks (go-gitea#21563) Handle OpenID discovery URL errors a little nicer when creating/editing sources (go-gitea#23397) Split CI pipelines (go-gitea#23385)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22649.