Fix missing collabrative repos #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
models/repo_list.go
Outdated
|
|
||
| searcherReposCond = searcherReposCond.Or(builder.In("owner_id", ownerIds)) | ||
| if opts.Collaborate { | ||
| searcherReposCond = searcherReposCond.Or(builder.Expr(`id IN (SELECT repo_id FROM "access" WHERE access.user_id = ? AND owner_id != ?)`, |
There was a problem hiding this comment.
"access" is not valid SQL, it should be `access` instead
|
LGTM |
tboerger
added
the
lgtm/need 1
|
Also will fix #2369 |
lunny
force-pushed
the
lunny/fix_collabrative_repos
branch
from
2ae0032
to
f36d0f8
Compare
|
LGTM |
|
make L-G-T-M work |
tboerger
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Aug 24, 2017
* fix missing collabrative repos * fix bug of collabrative * fix SQL quotes
lunny
added a commit
that referenced
this pull request
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. will fix #2365